Skip to content

feat(browser): add contact and address autofill #6

Closed

Description

@trmosala

Problem

Only login autofill exists.

Implementation order

Browser backlog item 02 of 29. Phase: Passwords and autofill. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Manage names, addresses, emails and phone numbers with persistence and deletion.
  • Recognise appropriate fields and preview the proposed fill for explicit user approval.
  • Validate ambiguous/hidden fields, navigation races and supported international address shapes.

Dependencies

No prerequisite backlog issue.

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 15, 2026

    @trmosala
    OwnerAuthor

    Implementation checkpoint: ce8f23c adds encrypted contact CRUD/editor and explicit native preview/fill. Autocomplete-only, one unambiguous top-frame section, exact select values, private active attached tab, vault/document/contact revision checks, no submit. South African/Japanese fixtures preserve address parts. Focused bun scripts/browser-smoke.ts --contacts passes; desktop/app typechecks pass; browser unit tests 30/30; scoped lint 0 errors. Read-only agent review findings fixed: detached views, multiline-input truncation, corruption affecting healthy passwords, edits during delivery. Already-dispatched scripts cannot be recalled; execution capped at five seconds. Remaining evidence: actual native long/multiline/RTL preview readability and keyboard interaction, macOS/packaged validation. Keeping issue open pending that evidence; no security-parity claim. Details: packages/cm-browser/password-security.md.

  2. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    Implemented and verified in ce8f23caa (feat(browser): add consent-based contact autofill), already pushed on browser-tabs.\n\nAcceptance coverage:\n- Encrypted persistent CRUD for names, addresses, email addresses, and phone numbers, including revision-safe editing and confirmed deletion.\n- Explicit native preview and default-cancel approval before fill; no automatic submission.\n- Exact autocomplete-based field recognition for one unambiguous visible top-frame section. Hidden, disabled, duplicate, mixed-section, unsafe destination, non-POST, stale-document, stale-contact, detached-view, and navigation-race cases fail closed.\n- South African multiline and Japanese address fixtures preserve international address parts; country selects require one exact option value.\n\nVerification on the current browser-tabs worktree:\n- bun scripts/browser-smoke.ts --contacts: PASS focused contacts / PASS native browser smoke.\n- bun test src/main/browser/: 256 pass, 0 fail, 3,086 expectations.\n- bun typecheck in packages/desktop: pass.\n- bun typecheck in packages/app: pass.\n- App native i18n tests: 12 pass, 0 fail, 480 expectations.\n- Scoped oxlint for the three contact implementation files: 0 errors, 1 existing type-assertion warning.\n\nPlatform limits remain documented in packages/cm-browser/password-security.md: this Linux/Electron run uses synthetic fixture consent and does not establish packaged Windows/macOS native-dialog accessibility or external password-manager assurance. Those are broader release-validation concerns rather than missing behavior in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions