Skip to content

refactor(browser): native settings rows in browser settings #59

Closed

Description

@trmosala

What to build

Browser settings look like the native settings screens. Bordered cards become divided rows, and titles and descriptions use the native settings typography. On/off options use the native switch, and choices use the settings-variant select. The new layout uses the v2 settings row. The native settings row is local to the general settings screen today, so it needs to become shareable without changing how native settings look.

This slice needs a human design review before merge.

Acceptance criteria

  • Browser settings sections render as divided rows that match native settings: row spacing, divider token, 14px medium title, and weak 12px description.
  • On/off options use the native switch control, with unchanged behaviour and accessible names.
  • Choice options use the native settings-variant select. Settings already hides the native page, so the popover cannot obscure the browser.
  • Under the new layout, rows use the v2 settings row.
  • The native settings row is shared without changing the appearance of native settings screens.
  • The inline style workaround in browser settings is removed.
  • Every setting saves and loads as before.
  • LTR and RTL both render correctly.
  • Scoped lint passes. Package typecheck passes where dependencies are installed.
  • Before/after screenshots are attached for both layouts, and a human design review is recorded on the PR.

Blocked by

Context

Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Operation, busy, error and recovery states belong to #43 and are out of scope. Another agent owns the tab-strip alignment; do not restyle the strip in this slice.

Activity

  1. added
    enhancementNew feature or request
    HITLRequires human validation or interaction
    ready-for-agentScoped work with acceptance criteria and recorded blockers
    on Oct 2, 2026
  2. trmosala commented on Oct 2, 2026

    @trmosala
    OwnerAuthor

    Implementation review evidence uploaded. Human review remains pending.

    Implementation is complete with shared classic/v2 settings rows, native switches and settings selects. Leaving this issue open because its required human design review has not been recorded on a PR.

    Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.

    Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.

    Full screenshot and validation archive

    classic, light, ltr

    Before

    Before: settings-general, classic, light, ltr

    After

    After: settings-general, classic, light, ltr

    classic, dark, rtl

    Before

    Before: settings-general, classic, dark, rtl

    After

    After: settings-general, classic, dark, rtl

    new, light, ltr

    Before

    Before: settings-general, new, light, ltr

    After

    After: settings-general, new, light, ltr

    new, dark, rtl

    Before

    Before: settings-general, new, dark, rtl

    After

    After: settings-general, new, dark, rtl

  3. trmosala commented on Oct 2, 2026

    @trmosala
    OwnerAuthor

    Implementation checkpoint saved; remaining acceptance work stays open.

    Native classic/v2 settings rows, switches and selects are committed. Before/after review images are attached in the earlier comment. The issue remains open for its required human design review recorded on a PR before merge.

    Local commit: 7f746e8fcb7d2ad819b107aac2c0d7d9462d1361 on branch browser-gaps. This commit has not been pushed, merged or released.

    Fresh checkpoint validation: 410 tests / 6,620 assertions pass; all five affected package typechecks and the browser plugin build pass; native navigation and leave-confirmation reruns pass; scoped lint has 0 errors and 356 style warnings; formatting and whitespace checks pass. Earlier native fixture results are documented in the committed cm-browser README. These checks do not qualify authenticated Teams, macOS or a packaged app.

    Native UI screenshot and validation archive. No installed app/server was restarted and no real account data was modified.

  4. trmosala commented on Oct 3, 2026

    @trmosala
    OwnerAuthor

    Closed at the user's explicit request after the implementation status was presented.

    Native classic/v2 settings rows, switches and selects are implemented and pushed on browser-gaps. Before/after images and validation are attached in the earlier comments. This closure does not merge the branch; no PR exists, and the design review required before merge remains a separate step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    HITLRequires human validation or interactionenhancementNew feature or requestready-for-agentScoped work with acceptance criteria and recorded blockers

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions