You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(browser): fit the native view inside the dock's rounded corners #58
The native browser view always fits inside the dock surface's rounded corners. The view is rectangular, and its bottom inset assumes a smaller corner radius than the dock surface may actually use. As a result, page pixels may draw past the rounded corners. A human needs to confirm this in a running desktop dev build and, if it reproduces, align the inset with the real host radius.
Acceptance criteria
A human confirms, in a running desktop dev build in both layouts, whether the native view overlaps the host's rounded corners. The finding is recorded on this issue with screenshots.
If the view overlaps, its inset matches the actual host corner radius and no page pixels draw outside the rounded corners.
If the view does not overlap, nothing changes and the issue records why.
Panel resize, display scaling and zoom keep the view inside the corners.
LTR and RTL both render correctly.
Scoped lint passes. Package typecheck passes where dependencies are installed.
Blocked by
None - can start immediately.
Context
Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Use a dev build for verification. Do not restart the installed app or server.
Implementation checkpoint saved; remaining acceptance work stays open.
No corner geometry change was made. Required human inspection in a running native Electron dev build is still pending; mounted Chromium images do not satisfy it.
Local commit: 7f746e8fcb7d2ad819b107aac2c0d7d9462d1361 on branch browser-gaps. This commit has not been pushed, merged or released.
Fresh checkpoint validation: 410 tests / 6,620 assertions pass; all five affected package typechecks and the browser plugin build pass; native navigation and leave-confirmation reruns pass; scoped lint has 0 errors and 356 style warnings; formatting and whitespace checks pass. Earlier native fixture results are documented in the committed cm-browser README. These checks do not qualify authenticated Teams, macOS or a packaged app.
Native qualification found no corner overlap; production geometry is unchanged.
The original audit conflated two hosts. The browser's session side panel has a 10px radius under the new layout; classic mode has no rounded radius. Its native viewport already has a measured 10 CSS-pixel bottom inset. The shared composer DockShell's 12px radius is not the browser host.
An isolated Electron 44.3.0 development fixture mounts the actual BrowserPanel, full app CSS, native commands and WebContentsView inside the actual session host classes. 108 geometry cases passed: both layouts, LTR/RTL, widths 940/620/390, renderer/page zoom 80/100/125%, and forced display scale 100/125/200%. The native page remains above the bottom corner band and inside the host's horizontal edges. A negative control with a 24px host radius correctly fails the unchanged-inset detector.
36 native-window images (24 full captures plus 12 corner close-ups), JSON measurements and runner sources are published here. Window captures assert that the green native child is present; these are not renderer-only screenshots. Green is the page, the strip beneath it is the host, and magenta is outside the host.
Fresh app/desktop typechecks passed; scoped viewport lint has zero warnings/errors. No production files changed. No installed app or server was restarted, and no live accounts or pages were modified. This fixture is not the full application shell, a macOS build or a packaged-release qualification.
Human inspection is still pending, so this issue remains open. An interactive isolated native dev fixture has been left open for the user, with Layout, Direction, Width and Zoom controls. The issue's first acceptance criterion explicitly requires a human finding; automated measurements and my inspection do not replace that step.
Closing on the user's explicit instruction: “Push and close.” The user approved the no-change disposition after the native evidence and review window were presented.
No corner overlap reproduced in 108 native Electron cases. The browser's actual session host has a 10px radius, matching its existing 10px bottom inset. Production geometry remains unchanged. App/desktop typechecks and scoped viewport lint pass.
The screenshots, measured bounds and runner sources are pushed in evidence commit 9ee084e791a8ab9dc8e002a82ca604179ece71e6. Remote commit identity was verified. Code branch browser-gaps remains at pushed commit ec2b9b79b87b8680a9d628a0712aa625cd5803ed; this issue requires no additional production-code commit.
The qualification comment and images retain the test boundaries: an isolated native development fixture using the actual browser components, CSS and native view code, rather than a complete app-shell, macOS or packaged-release qualification. Closure approval is recorded here; a separate human inspection result has not been independently reported.
Activity
trmosala commentedon Oct 2, 2026
Implementation checkpoint saved; remaining acceptance work stays open.
No corner geometry change was made. Required human inspection in a running native Electron dev build is still pending; mounted Chromium images do not satisfy it.
Local commit:
7f746e8fcb7d2ad819b107aac2c0d7d9462d1361on branchbrowser-gaps. This commit has not been pushed, merged or released.Fresh checkpoint validation: 410 tests / 6,620 assertions pass; all five affected package typechecks and the browser plugin build pass; native navigation and leave-confirmation reruns pass; scoped lint has 0 errors and 356 style warnings; formatting and whitespace checks pass. Earlier native fixture results are documented in the committed cm-browser README. These checks do not qualify authenticated Teams, macOS or a packaged app.
Native UI screenshot and validation archive. No installed app/server was restarted and no real account data was modified.
trmosala commentedon Oct 3, 2026
Native qualification found no corner overlap; production geometry is unchanged.
The original audit conflated two hosts. The browser's session side panel has a 10px radius under the new layout; classic mode has no rounded radius. Its native viewport already has a measured 10 CSS-pixel bottom inset. The shared composer DockShell's 12px radius is not the browser host.
An isolated Electron 44.3.0 development fixture mounts the actual BrowserPanel, full app CSS, native commands and WebContentsView inside the actual session host classes. 108 geometry cases passed: both layouts, LTR/RTL, widths 940/620/390, renderer/page zoom 80/100/125%, and forced display scale 100/125/200%. The native page remains above the bottom corner band and inside the host's horizontal edges. A negative control with a 24px host radius correctly fails the unchanged-inset detector.
36 native-window images (24 full captures plus 12 corner close-ups), JSON measurements and runner sources are published here. Window captures assert that the green native child is present; these are not renderer-only screenshots. Green is the page, the strip beneath it is the host, and magenta is outside the host.
Narrow 125% zoom, new RTL at 200% scale, full new layout at 100% scale, full classic layout at 100% scale.
Fresh app/desktop typechecks passed; scoped viewport lint has zero warnings/errors. No production files changed. No installed app or server was restarted, and no live accounts or pages were modified. This fixture is not the full application shell, a macOS build or a packaged-release qualification.
Human inspection is still pending, so this issue remains open. An interactive isolated native dev fixture has been left open for the user, with Layout, Direction, Width and Zoom controls. The issue's first acceptance criterion explicitly requires a human finding; automated measurements and my inspection do not replace that step.
trmosala commentedon Oct 3, 2026
Closing on the user's explicit instruction: “Push and close.” The user approved the no-change disposition after the native evidence and review window were presented.
No corner overlap reproduced in 108 native Electron cases. The browser's actual session host has a 10px radius, matching its existing 10px bottom inset. Production geometry remains unchanged. App/desktop typechecks and scoped viewport lint pass.
The screenshots, measured bounds and runner sources are pushed in evidence commit
9ee084e791a8ab9dc8e002a82ca604179ece71e6. Remote commit identity was verified. Code branchbrowser-gapsremains at pushed commitec2b9b79b87b8680a9d628a0712aa625cd5803ed; this issue requires no additional production-code commit.The qualification comment and images retain the test boundaries: an isolated native development fixture using the actual browser components, CSS and native view code, rather than a complete app-shell, macOS or packaged-release qualification. Closure approval is recorded here; a separate human inspection result has not been independently reported.