You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(browser): icons and shortcut hints in browser menus #57
The browser menu and the accounts menu look like native menus. Items have leading icons, and actions with browser shortcuts show their keybind hints. Under the new layout, the menu trigger matches the height of the tabs beside it.
Acceptance criteria
Browser menu and accounts menu items show leading icons in the native menu icon slot.
Items with a browser shortcut (for example find, print and reopen closed tab) show a keybind hint. Hints come from the same shortcut definitions the panel handles, not from duplicated strings.
Hints use the platform's modifier names (Cmd on macOS, Ctrl elsewhere).
Under the new layout, the menu trigger matches the tab height in the strip.
Menu keyboard navigation and actions behave as before.
The classic-layout appearance is unchanged outside the menus.
LTR and RTL both render correctly.
Scoped lint passes. Package typecheck passes where dependencies are installed.
Before/after screenshots are attached for each layout touched.
Blocked by
None - can start immediately.
Context
Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Operation, busy, error and recovery states belong to #43 and are out of scope. Another agent owns the tab-strip alignment; do not restyle the strip in this slice. A full v2 menu component swap is tracked separately.
Closing at the user's request after implementation and review.
Browser/accounts menu items have native leading icons and platform keybind hints from the shortcut definitions used by the dispatcher. The new-layout trigger matches tab height.
Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.
Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.
Activity
trmosala commentedon Oct 2, 2026
Closing at the user's request after implementation and review.
Browser/accounts menu items have native leading icons and platform keybind hints from the shortcut definitions used by the dispatcher. The new-layout trigger matches tab height.
Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.
Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.
Full screenshot and validation archive
classic, light, ltr
Before
After
classic, dark, rtl
Before
After
new, light, ltr
Before
After
new, dark, rtl
Before
After