Skip to content

feat(browser): native address field in both layouts #55

Closed

Description

@trmosala

What to build

The address field looks and behaves like a native text field: the classic text field in the classic layout and the v2 text input in the new layout. Its combobox behaviour stays intact.

Acceptance criteria

  • In the classic layout, the address field's background, border and radius match the native text field. In the new layout, they match the v2 text input.
  • Focus shows the native focus ring instead of only recolouring the border.
  • The field has a native hover state.
  • The field uses native text sizing for each layout.
  • Under the new layout, the embedded site, submit and bookmark buttons use native embedded-button sizing.
  • Combobox behaviour is unchanged: suggestions, keyboard navigation and submit work as before.
  • The classic-layout appearance is unchanged outside the address field.
  • LTR and RTL both render correctly.
  • Scoped lint passes. Package typecheck passes where dependencies are installed.
  • Before/after screenshots are attached for each layout touched.

Blocked by

None - can start immediately.

Context

Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Operation, busy, error and recovery states belong to #43 and are out of scope. Another agent owns the tab-strip alignment; do not restyle the strip in this slice.

Activity

  1. added
    enhancementNew feature or request
    ready-for-agentScoped work with acceptance criteria and recorded blockers
    on Oct 2, 2026
  2. trmosala commented on Oct 2, 2026

    @trmosala
    OwnerAuthor

    Closing at the user's request after implementation and review.

    Address controls now use the classic/v2 native field metrics, borders, hover/focus states and embedded button sizing, preserving combobox behavior.

    Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.

    Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.

    Full screenshot and validation archive

    classic, light, ltr

    Before

    Before: suggestions, classic, light, ltr

    After

    After: suggestions, classic, light, ltr

    classic, dark, rtl

    Before

    Before: suggestions, classic, dark, rtl

    After

    After: suggestions, classic, dark, rtl

    new, light, ltr

    Before

    Before: suggestions, new, light, ltr

    After

    After: suggestions, new, light, ltr

    new, dark, rtl

    Before

    Before: suggestions, new, dark, rtl

    After

    After: suggestions, new, dark, rtl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestready-for-agentScoped work with acceptance criteria and recorded blockers

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions