Skip to content

fix(browser): native highlight and hover in address suggestions #52

Closed

Description

@trmosala

What to build

Address suggestions look and respond like native menu items. Rows highlight on pointer hover as well as keyboard navigation, using the native menu hover surface instead of the tab strip's background. The new layout gets the v2 menu row treatment.

Acceptance criteria

  • Hovering a suggestion row with the pointer highlights it with the native menu-item hover surface. The keyboard highlight uses the same surface.
  • The highlighted row is visually distinct from the tab strip background.
  • Suggestion rows use native menu row padding and radius.
  • Under the new layout, rows use the v2 menu hover overlay and row metrics.
  • Suggestions stay in normal page flow rather than a popover, so opening them never hides the native page.
  • Keyboard navigation and selection behave as before.
  • The classic-layout appearance is unchanged except for the suggestion rows.
  • LTR and RTL both render correctly.
  • Scoped lint passes. Package typecheck passes where dependencies are installed.
  • Before/after screenshots are attached for each layout touched.

Blocked by

None - can start immediately.

Context

Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Operation, busy, error and recovery states belong to #43 and are out of scope. Another agent owns the tab-strip alignment; do not restyle the strip in this slice.

Activity

  1. added
    bugSomething isn't working
    ready-for-agentScoped work with acceptance criteria and recorded blockers
    on Oct 2, 2026
  2. trmosala commented on Oct 2, 2026

    @trmosala
    OwnerAuthor

    Closing at the user's request after implementation and review.

    Suggestion pointer and keyboard highlights share native menu styling. Suggestions remain in normal flow.

    Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.

    Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.

    Full screenshot and validation archive

    classic, light, ltr

    Before

    Before: suggestions, classic, light, ltr

    After

    After: suggestions, classic, light, ltr

    classic, dark, rtl

    Before

    Before: suggestions, classic, dark, rtl

    After

    After: suggestions, classic, dark, rtl

    new, light, ltr

    Before

    Before: suggestions, new, light, ltr

    After

    After: suggestions, new, light, ltr

    new, dark, rtl

    Before

    Before: suggestions, new, dark, rtl

    After

    After: suggestions, new, dark, rtl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-agentScoped work with acceptance criteria and recorded blockers

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions