Skip to content

fix(browser): align toolbar geometry and control states #50

Closed

Description

@trmosala

What to build

The browser toolbar lines up with the tab strip and follows native control-state conventions. It keeps the same inline inset and control spacing as the strip, stays on one row, and shows disabled, pressed and expanded states the way native toolbars do.

Acceptance criteria

  • The toolbar's inline inset and control spacing match the tab strip's, so the back button lines up with the first tab.
  • The toolbar stays on a single row at narrow panel widths. The address field shrinks instead of the bar wrapping.
  • Disabled back and forward buttons look disabled, using the native disabled icon colour. Enabled buttons look as before.
  • The element picker, site information and bookmark controls share one native pressed/expanded appearance, driven by their existing accessible state. The picker no longer uses a raised secondary chip when active.
  • Reload/stop has a localized label exposed as its tooltip, like its neighbours.
  • Every toolbar control shows a visible keyboard focus state.
  • Open question: the reload glyph is nearly identical to the submit arrow in the same bar. Propose a distinct native glyph in the PR, or record why the current glyph stays. The reviewer decides.
  • The classic-layout appearance is unchanged except for the changes listed above.
  • LTR and RTL both render correctly.
  • Scoped lint passes. Package typecheck passes where dependencies are installed.
  • Before/after screenshots are attached for each layout touched.

Blocked by

None - can start immediately.

Context

Source: browser panel native-styling audit, 2 October 2026. Coordinate with ongoing browser changes in #37–#48. Operation, busy, error and recovery states belong to #43 and are out of scope. Another agent owns the tab-strip alignment; do not restyle the strip in this slice.

Activity

  1. added
    bugSomething isn't working
    ready-for-agentScoped work with acceptance criteria and recorded blockers
    on Oct 2, 2026
  2. trmosala commented on Oct 2, 2026

    @trmosala
    OwnerAuthor

    Closing at the user's request after implementation and review.

    Toolbar stays on one row with aligned spacing, native disabled/pressed/focus states, and a usable address field at narrow widths. The current reload glyph remains while the reviewer considers the circular-reload proposal, avoiding an unapproved icon choice.

    Validation: 18 tests pass with 514 assertions; app package typecheck passes; scoped lint reports 0 errors and 25 warnings; formatting and diff checks pass. Mounted Chromium fixtures cover both layouts, light/dark themes and LTR/RTL. They do not verify native Electron corners.

    Implementation remains uncommitted in the isolated browser-gaps worktree. Closure records completion of the local implementation, not a merge or release.

    Full screenshot and validation archive

    classic, light, ltr

    Before

    Before: narrow, classic, light, ltr

    After

    After: narrow, classic, light, ltr

    classic, dark, rtl

    Before

    Before: narrow, classic, dark, rtl

    After

    After: narrow, classic, dark, rtl

    new, light, ltr

    Before

    Before: narrow, new, light, ltr

    After

    After: narrow, new, light, ltr

    new, dark, rtl

    Before

    Before: narrow, new, dark, rtl

    After

    After: narrow, new, dark, rtl

    280px toolbar review

    Reload glyph proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingready-for-agentScoped work with acceptance criteria and recorded blockers

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions