Skip to content

feat(browser): complete saved-account management #5

Closed

Description

@trmosala

Problem

Current manager saves from pages, fills and deletes; direct creation/editing is incomplete.

Implementation order

Browser backlog item 01 of 29. Phase: Passwords and autofill. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Add account search and explicit account creation/editing, including username and password replacement.
  • Keep secrets outside the app renderer; use the established vault and native consent boundary.
  • Verify validation, duplicates, cancellation, locked state and concurrent edits.

Dependencies

No prerequisite backlog issue.

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 15, 2026

    @trmosala
    OwnerAuthor

    Windows-first implementation pushed as bc4040b: account search, native CredUI create/edit, default-cancel save consent, duplicate/concurrent-edit rejection, vault lock checks. Focused synthetic account/vault fixture and decoder cases pass; seven vault/import tests, desktop/app typechecks and helper build pass. Scoped lint has warnings, no errors. Keeping open: macOS native entry and actual native-entry/packaged validation are not complete. Evidence and limitations: packages/cm-browser/password-security.md. Continuing ordered backlog with #6.

  2. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    Implemented saved-account search and explicit create/edit flows with main-process vault ownership, native consent, duplicate and concurrent-edit checks, cancellation handling, and locked-state enforcement. Added native macOS AppKit credential entry plus build and packaging wiring; Windows CredUI behavior remains unchanged. Desktop typecheck, the 256-test browser suite, focused packaging/authentication tests, scoped lint, formatting, and whitespace checks pass. Actual AppKit and packaged macOS execution still require validation on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions