Skip to content

feat(browser): allow search-engine selection #31

Closed

Description

@trmosala

Problem

DuckDuckGo is the fixed search engine.

Implementation order

Browser backlog item 27 of 29. Phase: Optional conveniences. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Keep DuckDuckGo as default while supporting explicit alternative selection.
  • Validate search templates and preserve direct URL/local-address navigation.
  • Test encoding, migration and privacy; suggestions remain local unless separately enabled.

Dependencies

No prerequisite backlog issue.

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 18, 2026

    @trmosala
    OwnerAuthor

    Implemented and published in 25f3e0cf9 (feat(browser): add search engine selection).

    • DuckDuckGo remains the default; Browser settings explicitly offers DuckDuckGo, Google, and Bing.
    • Search destinations come from a closed, typed registry. Templates must be HTTPS, credential-free, fragment-free, and expose one safe query parameter; submitted text is encoded with URLSearchParams.
    • Direct HTTP(S) URLs, bare domains, localhost, IPv4 loopback, IPv6 loopback, and host:port development addresses are resolved before search and behave identically for every engine.
    • Profiles without the new field, legacy DuckDuckGo values, and invalid stored values read as DuckDuckGo. Invalid writes are rejected by main.
    • Address suggestions remain a pure local merge of current-task tabs, bookmarks, and history. No remote autocomplete or suggestion request was added; only submitting search text contacts the selected engine.
    • The address placeholder and landing page reflect the current engine.

    Verification:

    • address/search/template/migration and local-suggestion tests: 17 passed / 58 expectations
    • mounted Browser settings and preview tests: 2 passed / 165 expectations
    • app and desktop typechecks: PASS
    • scoped oxlint: 0 errors (existing warnings remain)
    • pre-push workspace typechecks: 31/31 PASS

    No installed CookieMonster process or bridge was restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions