Skip to content

feat(browser): expand device preview controls #24

Closed

Description

@trmosala

Problem

Mobile preview is fixed at 390 by 844.

Implementation order

Browser backlog item 20 of 29. Phase: Settings and developer features. This is ordered planning, not a claim that Codex implements every item. Items 24ΓÇô29 are optional additions.

Acceptance criteria

  • Add custom sizes, orientation and supported touch settings.
  • Retain actual Chromium identity and accurately describe emulation limits.
  • Verify layout and restoration when preview is disabled.

Dependencies

No prerequisite backlog issue.

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Acceptance checkpoint: ff96a0e

Published and remote-verified on browser-tabs. Custom integer sizes (160-4096 CSS px), width/height swapping, actual Chromium identity, fit-to-panel and disable/restoration are implemented and verified with synthetic Windows fixtures. Touch and sensors are unsupported by the selected Electron device API; no nonfunctional setting was added. Per-tab presentation is memory-only.

Evidence: #24 (comment) . Combined-tree typechecks, 167 desktop tests/2440 expectations, 26 app tests/597 expectations and separate serial capture-selection, offer-arming and default native runs passed. The delayed-arming fixture defect and stale-capture A-B-A defect have RED/GREEN evidence. Historical intermittent login-offer timeout causation remains unproven.

Acceptance remains OPEN for packaged/platform/physical-accessibility and reviewed-translation evidence; detached-background screenshot LIMIT remains. This is not full device emulation, fixture-stability proof or external assurance. #20 design gates and #19/#34 external blockers are unchanged.

Activity

  1. trmosala commented on Sep 17, 2026

    @trmosala
    OwnerAuthor

    Published ff96a0e: 14 reviewed implementation/test/documentation files, rebased onto a3b77ee with identical range-diff, fast-forward merged into browser-tabs and pushed. Local and remote SHAs match. Download admission/cancellation safeguards preserved. Custom 160-4096 CSS-pixel dimensions, orientation swapping, native fit and restoration retain Chromium identity. Touch and sensor emulation are explicitly unsupported by the selected Electron API; no placeholder control or debugger takeover. Per-tab settings are not persisted. Captures now latch obsolete across tab/session A-B-A transitions through native work and renderer delivery; menu disposal and viewport acknowledgement precede screenshot capture. Native and twelve mounted renderer stale-delivery cases were RED before correction and GREEN afterward. Concrete timeout hypothesis tested: hold actual login-offer renewal beyond expiry; trusted submission arrived with null capture and no Never exclusion. Existing readiness acknowledgement before eligible synthetic input fixes that fixture regression, retaining the original 800 ms delay and production leases/guards. The historical intermittent timeout remains unattributed; this is not a claim of general fixture stability. Combined-tree verification: desktop/app typechecks PASS; desktop 167 tests / 2440 expectations; app scoped mounted/browser/i18n 26 / 597; separate serial disposable --capture-selection, --offer-arming and default native PASS, including preview/restoration and download cancellation. Earlier corrected preview tree also passed serial --tab-lifecycle and --screenshots, with detached-background screenshot LIMIT retained. Prettier 3.6.2 PASS after local CRLF-to-LF normalization; no tracked content changed and no extra commit was created. Scoped lint: 93 warnings, zero errors, including new code. Normal push hook: 31/31 typecheck tasks passed, 28 cached. Synthetic Windows evidence, not packaged/macOS/Linux/physical-accessibility or external assurance; Happy DOM emitted multiple-Solid-instances warning. #24 remains open for those acceptance limits. #20 task recovery remains design-gated; #19/#34 external inputs remain missing; #21 restart-resume is not implemented. No release, deployment, installed-process restart or unrelated-file changes. Details: packages/cm-browser/README.md and password-security.md at the published commit.

  2. trmosala commented on Sep 22, 2026

    @trmosala
    OwnerAuthor

    Validated on macOS arm64 in commit cc308d7. Detailed evidence and limitations.

    The final full native run passes custom dimensions, rotation and restoration when preview is disabled. Capture-selection and persisted presentation fixtures also pass. Actual Chromium identity is retained; touch/sensor emulation remains explicitly unsupported. Closing the bounded feature acceptance. Historical timeout/occlusion findings remain documented; physical, packaged, accessibility and external assurance remain #34/#35 gates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions