Skip to content

feat(browser): add guided browser import #22

Closed

Description

@trmosala

Problem

Imports currently require selected CSV, cookie JSON or bookmark HTML files.

Implementation order

Browser backlog item 18 of 29. Phase: Compatibility and recovery. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Provide source selection, preview, deduplication and per-category results.
  • Reuse supported browser exports where direct access is unavailable; do not bypass OS credential protection.
  • Cover unavailable/locked sources, malformed files and partial cookie import results.

Dependencies

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Acceptance checkpoint: 98dd3c0

Published and remote-verified on browser-tabs. Supported selected CSV/JSON/HTML exports now have source selection, count-only preview, deduplication, default-Cancel confirmation and category results. Locked/unavailable/malformed inputs and partial cookie writes are covered. No OS protection bypass or profile scraping.

Evidence: #22 (comment) . Both IPv4 identity and indexed-i18n review findings are resolved with RED/GREEN evidence and final source-only clearances. Separate serial imports43/default/persistence11 passed; existing results were reused during publication. Physical consent/authentication, packaged/platform behavior, reviewed translations and external assurance remain unverified. Cookies remain sequential, process-local and non-atomic; no rollback or replay. Issue remains open for those validation limits; implementation proceeds to #23.

Activity

  1. trmosala commented on Sep 17, 2026

    @trmosala
    OwnerAuthor

    Published 98dd3c0 on browser-tabs; local and remote SHAs verified equal. Exactly 14 scoped files, 1047 insertions/96 deletions. Native CSV password, JSON cookie and HTML bookmark selection now leads to default-Cancel count review, confirmed import and category results. Exports stay main-only; no profile scraping, OS bypass or page/vault grant expansion. Stable account IDs, repeated-import no-ops, original vault/owner identity and stale destination refusal are covered. Cookie results report successful/failed/unattempted writes and flush uncertainty; no atomicity, rollback or replay claim. Both review blockers resolved: IPv4 Domain attributes normalized to Chromium host-only identity before planning, and import translations appended after the original 217 indexed keys with English unchanged. Four IPv4 production-command regressions and fixed i18n-prefix regression have RED/GREEN evidence; malformed JSON sanitization also RED/GREEN. Other coverage is GREEN-only. Final source-only correctness and standards reviews cleared the cumulative slice; reviewers and editor returned terminal reports and relinquished ownership. Initial desktop browser suite: 169 tests/2449 expectations. After corrections: desktop/app typechecks PASS; desktop parser/bookmark 9/43, app native-i18n 10/459; separate serial --imports 43 cases, default once and --persistence-reopen 11 phases once PASS. No completed native work was repeated during publication. Initial scoped lint 89 warnings/0 errors, correction scope 17 warnings/0 errors; scoped Prettier and staged whitespace PASS. Normal push hooks: 31/31 typecheck tasks, 28 cached. Disposable fixtures cleaned; excluded files and installed processes unchanged. No release/deployment. Limits: sequential process-local cookies, check-to-write/external-writer races, no physical disk durability or string-zeroization guarantee; IPv6/noncanonical IPv4/partitioned/container cookies unsupported. Physical chooser/authentication, packaged/macOS/Linux, reviewed translations and external assurance are not established. Acceptance remains bounded to supported selected exports and synthetic Windows evidence; issue stays open for remaining validation. See packages/cm-browser/README.md and password-security.md at this commit. Next actionable work: #23. #20/#21 design/product gates and #19/#34 external gates unchanged.

  2. trmosala commented on Sep 22, 2026

    @trmosala
    OwnerAuthor

    Validated on macOS arm64 in commit cc308d7. Detailed evidence and limitations.

    The guided import workflow passes all 43 native production-flow cases: source selection, preview/cancel, deduplication, stable IDs, locked/unavailable/malformed inputs, partial cookie writes and stale consent. Fixed fixture lifecycle ordering without weakening production locking. Closing the bounded feature acceptance; physical authentication, packaged acceptance, accessibility and external security assurance remain tracked by #34/#35. Selected browser exports only; no OS protection bypass, atomic cookie rollback or replay claim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions