You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(browser): support frame-aware browser workflows #17
Agent snapshots/input and guarded file choosers do not support iframe workflows; password filling is top-frame only.
Implementation order
Browser backlog item 13 of 29. Phase: Compatibility and recovery. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.
Acceptance criteria
Introduce frame identity and origin-aware references for supported page operations.
Add consent-aware iframe file selection; treat frame password filling as a separate explicit origin boundary.
Test cross-origin frames, frame replacement, navigation and revoked access.
Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.
Published on browser-tabs: 0e89d57 (feat(browser): add origin-bound frame workflows), based on c8ce338. Local HEAD and remote branch match; exactly 24 task files committed. Excluded files remain untouched. Normal pre-push hooks passed 31/31 typecheck tasks.
Implemented bounded direct ordinary HTTP(S) child-frame discovery, separate exact top/receiver-origin approval for child reads and native single-select operations, origin/document/session-bound references, and consent-aware native iframe file selection. Same-origin and real out-of-process frames are supported. Child password filling stays explicitly unsupported: native frame targeting rejects rather than falling back to the top page, and credential scripts reject child documents. Child pointer/keyboard/waits, nested/opaque/sandboxed and unsupported geometry remain refused.
Verification: desktop browser tests 154 passed / 2,252 expectations; cm-browser 81 / 3,254; native-i18n 9 / 458; desktop, plugin and app typechecks passed. Final serial --frames passed 81 upload, 57 read and 86 selection cases plus discovery/top-input regressions. Final separate default native suite passed after all production corrections. Formatting and staged whitespace checks passed. Scoped lint had zero errors, with warnings and exact scopes recorded in README.
Independent cumulative correctness/spec and standards source reviews are clear after native regressions corrected production owner-ID mismatch, receiver-host revoke/regrant, metadata-cap degradation, border/legacy/paint containment clipping, and top-input focus/wrapping cases. Tests include real same-origin/OOPIF siblings, replacement/navigation, held consent/results, policy/access revocation, selected-file isolation and password negatives.
Evidence and limits: packages/cm-browser/README.md#frame-aware-workflows-17 and password-security.md. Dialog choices and selected files are synthetic fixture seams. Dispatch/delivery is non-atomic and delivered effects cannot be recalled. English-fallback translation review, physical/accessibility/native usability, packaged and cross-platform validation, and external #34 assurance remain open. This publishes the bounded implementation, not unrestricted iframe or Chromium-security parity; keeping the issue open for those gates. Continuing next with #18.
Completed validation and pushed 6845260 (test(browser): validate frame workflows on macOS) to browser-tabs. The bounded feature implementation already existed in 0e89d57; this follow-up corrects native-fixture readiness and records current evidence. Dependencies #13 and #14 are closed.
Acceptance criteria are covered: origin/document/session-bound frame references for supported reads and single-select, explicit origin-aware consent for iframe file selection, and rejection of child password filling rather than implicit top-frame fallback. Focused native coverage includes same-origin and OOPIF frames, replacement, navigation, revoked access, held consent/results and password negatives. Independent standards and correctness/spec reviews found no actionable gaps.
Validation on macOS arm64 / Electron 44.3.0 / Chromium 152.0.7977.78:
Serial focused --frames PASS.
Separate full default native smoke PASS, including guarded OOPIF chooser cancellation with zero pickers/files. Corrected the test to await the loaded guarded execution context rather than only target attachment, plus renderer viewport measurements after resize. Production authority and consent checks are unchanged.
Both package typechecks PASS; normal push hook 31/31 successful (29 cached).
Formatting/whitespace PASS; scoped native-smoke lint 58 warnings, zero errors.
Remaining limits are recorded rather than claimed green: native-i18n is 12 PASS / 1 FAIL because pa-PK detection returns en instead of the expected pa; locale code is unchanged. The passing native suite still emits a Chromium observer-list reentrancy diagnostic whose cause is unestablished. Physical/native-dialog accessibility, reviewed translations, packaged builds, Linux and external #34 assurance remain separate work. Closing the bounded #17 acceptance criteria, not claiming unrestricted iframe support or Chromium security parity. Updated evidence is in packages/cm-browser/README.md and password-security.md.
Activity
trmosala commentedon Sep 17, 2026
Published on browser-tabs: 0e89d57 (feat(browser): add origin-bound frame workflows), based on c8ce338. Local HEAD and remote branch match; exactly 24 task files committed. Excluded files remain untouched. Normal pre-push hooks passed 31/31 typecheck tasks.
Implemented bounded direct ordinary HTTP(S) child-frame discovery, separate exact top/receiver-origin approval for child reads and native single-select operations, origin/document/session-bound references, and consent-aware native iframe file selection. Same-origin and real out-of-process frames are supported. Child password filling stays explicitly unsupported: native frame targeting rejects rather than falling back to the top page, and credential scripts reject child documents. Child pointer/keyboard/waits, nested/opaque/sandboxed and unsupported geometry remain refused.
Verification: desktop browser tests 154 passed / 2,252 expectations; cm-browser 81 / 3,254; native-i18n 9 / 458; desktop, plugin and app typechecks passed. Final serial --frames passed 81 upload, 57 read and 86 selection cases plus discovery/top-input regressions. Final separate default native suite passed after all production corrections. Formatting and staged whitespace checks passed. Scoped lint had zero errors, with warnings and exact scopes recorded in README.
Independent cumulative correctness/spec and standards source reviews are clear after native regressions corrected production owner-ID mismatch, receiver-host revoke/regrant, metadata-cap degradation, border/legacy/paint containment clipping, and top-input focus/wrapping cases. Tests include real same-origin/OOPIF siblings, replacement/navigation, held consent/results, policy/access revocation, selected-file isolation and password negatives.
Evidence and limits: packages/cm-browser/README.md#frame-aware-workflows-17 and password-security.md. Dialog choices and selected files are synthetic fixture seams. Dispatch/delivery is non-atomic and delivered effects cannot be recalled. English-fallback translation review, physical/accessibility/native usability, packaged and cross-platform validation, and external #34 assurance remain open. This publishes the bounded implementation, not unrestricted iframe or Chromium-security parity; keeping the issue open for those gates. Continuing next with #18.
trmosala commentedon Sep 22, 2026
Completed validation and pushed 6845260 (test(browser): validate frame workflows on macOS) to browser-tabs. The bounded feature implementation already existed in 0e89d57; this follow-up corrects native-fixture readiness and records current evidence. Dependencies #13 and #14 are closed.
Acceptance criteria are covered: origin/document/session-bound frame references for supported reads and single-select, explicit origin-aware consent for iframe file selection, and rejection of child password filling rather than implicit top-frame fallback. Focused native coverage includes same-origin and OOPIF frames, replacement, navigation, revoked access, held consent/results and password negatives. Independent standards and correctness/spec reviews found no actionable gaps.
Validation on macOS arm64 / Electron 44.3.0 / Chromium 152.0.7977.78:
Remaining limits are recorded rather than claimed green: native-i18n is 12 PASS / 1 FAIL because pa-PK detection returns en instead of the expected pa; locale code is unchanged. The passing native suite still emits a Chromium observer-list reentrancy diagnostic whose cause is unestablished. Physical/native-dialog accessibility, reviewed translations, packaged builds, Linux and external #34 assurance remain separate work. Closing the bounded #17 acceptance criteria, not claiming unrestricted iframe support or Chromium security parity. Updated evidence is in packages/cm-browser/README.md and password-security.md.