Skip to content

feat(browser): improve agent page snapshots #14

Closed

Description

@trmosala

Problem

Snapshots use bounded document queries and do not comprehensively describe accessible names, state or shadow DOM.

Implementation order

Browser backlog item 10 of 29. Phase: Agent browsing. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Improve accessible naming and checked/selected/expanded/disabled state.
  • Support relevant shadow DOM while keeping output bounded and credential values excluded.
  • Test custom controls, duplicate names, stale refs and sensitive fields.

Dependencies

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 16, 2026

    @trmosala
    OwnerAuthor

    Published and remote-confirmed: 40f4d95. One commit and normal push, 11 reviewed files; pre-push typechecks 31/31 (29 cached). Only the two excluded unrelated files remain dirty.

    Snapshots now use isolated-world node identity, bounded names/states and open-shadow traversal, excluding editable values/content. Review regressions cover insecure HTTP tokens, changed-input fill preflight, automatic slot names and conservative omission of manual-slot projection names. Final correctness and standards reviews found no actionable findings.

    Final parent verification: 93 browser tests / 1,432 expectations and full isolated native smoke passed after all production fixes. Plugin 40 tests and both package typechecks passed; completed unaffected tests were not replayed for publication. Scoped lint had warnings; unrelated root lint error at session-ui prompt-input:163 remains untouched.

    Not full ARIA or atomic dispatch. Manual-slot names are omitted/truncated rather than guessed; platform/native accessibility, macOS/Linux, prior localization and separate #34 assurance gates remain open. No release, installed-app/bridge restart or model change. Issue remains open for those gates; continuing #13 on the published snapshot boundary. #20 timeout evidence remains recorded, including #20 (comment).

  2. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    Implemented in 40f4d95, with the macOS contenteditable fill regression fixed and pushed in cb2472b. The native snapshot smoke now passes on macOS, covering names/states, editable-value exclusion, duplicate names, shadow DOM/slots, stale references and bounded output. Verification: 257 desktop browser tests passed, desktop typecheck passed, pre-push typechecks 31/31 passed, scoped lint had 0 errors and 12 warnings. This closes the scoped implementation; broader packaged-app, physical accessibility/input, translation and release-assurance validation remain separate work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions