Skip to content

feat(browser): offer contextual saved-account selection #10

Closed

Description

@trmosala

Problem

Filling currently requires opening the password manager.

Implementation order

Browser backlog item 06 of 29. Phase: Passwords and autofill. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Offer exact-origin matching accounts in the login workflow with explicit selection.
  • Preserve vault locking, native consent, agent exclusion and no automatic submission.
  • Cover multiple accounts, username/password-only steps and document replacement.

Dependencies

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 16, 2026

    @trmosala
    OwnerAuthor

    Published on browser-tabs: ef7cb7f, feat(browser): add contextual account selection.
    ef7cb7f

    Scope: exactly ten owned files. Exact-origin saved-account metadata with explicit Fill / Username / Password actions, no automatic selection/fill/submission, acknowledged native viewport reattachment before dispatch, and document/field preparation before default-cancel native consent. Vault-generation, private-tab, active session/view and revision guards remain authoritative. Failed preparation/delivery now publishes the advanced revision so fresh explicit retries work.

    Regression evidence: mounted Fill on a username-only step failed before the fix, then Username returned Login selection expired. After the fix, mounted preparation-failure and field-replacement delivery-failure retries pass without manual publication/reset/navigation/state requests between attempts. Fixture request snapshots check menu disposal and received viewport acknowledgement without an artificial awaited renderer inspection before browserCommand; main checks physical native-view membership.

    Final complete ten-file source review ses_f5905c6a3ffeYlhAvgmZBvPSmg against e366d28 found no actionable findings after those fixes. Source-only review, not external security assurance.

    Final checks already completed:

    • App browser-panel unit tests: 15 pass; app bun run test:browser: 41 pass.
    • Desktop bun test src/main/browser: 31 pass; app and desktop bun typecheck: pass.
    • Desktop bun scripts/browser-smoke.ts --account-fill and full bun scripts/browser-smoke.ts: pass, no concurrent native fixtures. Full run emitted Mojo and expected /fail ERR_EMPTY_RESPONSE diagnostics.
    • Scoped Prettier/diff checks: pass; scoped oxlint: 74 warnings, 0 errors.
    • Full app bun run test:unit: 737 pass, 4 fail in unchanged i18n parity. Isolated parity: 1 pass, 4 fail; missing Arabic desktop keys and invalid hr.ts dictionary. i18n diff against e366d28 is empty. Record as separate translation follow-up; no unrelated translation changes included.

    Publication updated existing password-security.md review evidence only, without rerunning completed feature tests. One commit and one normal push, hooks enabled; pre-push typecheck: 31/31 successful, 28 cached. Remote branch hash verified equal to local HEAD; all ten owned files clean and both excluded files untouched.

    Keeping #10 OPEN: synthetic Windows Chromium/encrypted-storage fixtures stub OS authentication and native dialog choices. Packaged preload/IPC timing, native accessibility/usability, macOS/platform builds, and external #34 assurance remain unverified. Already-dispatched fills cannot be recalled; an authorized website can read filled values. No release/deployment or installed app/server/bridge restart.

  2. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    Implemented by ef7cb7f (feat(browser): add contextual account selection) and published on browser-tabs.\n\nVerified again on 2026-09-21:\n- packages/app: bun run test:browser (43 passed)\n- packages/app: bun typecheck\n- packages/desktop: bun test src/main/browser/ (257 passed)\n- packages/desktop: bun typecheck\n- packages/desktop: bun scripts/browser-smoke.ts --account-fill\n- push hook: repository typecheck (31/31 packages)\n- standards and issue-spec reviews: no actionable findings\n\nThe implementation provides exact-origin explicit account selection, Fill/Username/Password actions, main-process ownership and native default-cancel consent, vault/agent/document guards, and no automatic submission. Synthetic coverage includes multiple accounts, split login steps, stale document/field replacement, and retries.\n\nPackaged-platform, physical accessibility/usability, and external security assurance remain tracked separately in #34; they are release-assurance work rather than missing #10 behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions