Feature/24#35
Open
netstyler wants to merge 6 commits into
Open
Conversation
fixed issue with Uncaught ReferenceError: timeoutId is not defined
as it seams to work fine on my side
| var dlHeight = []; | ||
|
|
||
| for (i = 0; i < columns.length; ++i) { | ||
| for (j = 0; j < columns[i].length; ++j) { |
Owner
There was a problem hiding this comment.
This loop is not necessary as the height of the column only depends on its last element
There was a problem hiding this comment.
@netstyler should just be able to replace it with
// Calculate the full container height
var columnsHeights = getColumnsHeights(cols);
angular.element('[dynamic-layout]').css('height', Math.max.apply(null, columnsHeights));
Thanks to @aschmoe and his comment: tristanguigue#35 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue that no height is set of the dynamic layout container | fixes #24
Get the columns and get the lowest items with there heights.
Then get biggest item position and set it as dynamic-layout height