Fix #161: Apply landscape keyboard height dynamically on orientation … - #164
Open
FarzanArzoiy wants to merge 1 commit into
Open
Fix #161: Apply landscape keyboard height dynamically on orientation …#164FarzanArzoiy wants to merge 1 commit into
FarzanArzoiy wants to merge 1 commit into
Conversation
…ientation change and preference update - Add refreshKeyboardHeight() that recalculates height from NeuralLayoutBridge - Call it in onConfigurationChanged() when device rotates - Call it in onSharedPreferenceChanged() when height-related prefs change - This makes the landscape slider work immediately and keeps portrait/landscape heights independent
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes Issue #161: the landscape height slider did nothing, while the portrait slider controlled both orientations.
Root cause: the keyboard height was calculated once on initial layout and never updated when:
Solution:
refreshKeyboardHeight()method that recalculates the height usingNeuralLayoutBridge(which already knows how to pick the correct preference based on orientation and foldable state) and applies it to the keyboard view.onConfigurationChanged()so the height updates immediately when the device rotates.onSharedPreferenceChanged()when any height‑related preference (keyboard_height,keyboard_height_landscape, etc.) changes, so the landscape slider takes effect instantly.Impact: users can now set independent heights for portrait and landscape, and both sliders work correctly. No other behaviour is altered.
Type of Change
Related Issues
Closes #161
Related to #161
Changes Made
refreshKeyboardHeight()method inCleverKeysService.kt.onConfigurationChanged()afterrefresh_config().onSharedPreferenceChanged()and calledrefreshKeyboardHeight().Testing Performed
Manual Testing
Test Device:
Test Scenarios:
Results:
All tests pass. The landscape slider now works exactly as expected, and orientation switching updates the height correctly.
Automated Testing
./gradlew test ./gradlew lint