Repository navigation
chore(skills): drop the /root/skills install and link layer - #112
Merged
Merged
Conversation
The sandbox-wide canonical skills catalog is moving to ~/.agents/skills (tribes-protocol/terminal skills-path move). ata's agent is pi, which reads ~/.agents/skills natively (pi docs/skills.md: Global: ~/.pi/agent/skills/, ~/.agents/skills/), so this repo no longer installs or links /root/skills at all. The vendored zipbox-* skills stay as real directories under repo-root skills/, discovered through the checked-in .pi/skills and .claude/skills symlinks; skills:upgrade vendoring is unchanged. Removed outright (no compat path left behind): - scripts/install-shared-skills.sh — the /root/skills installer + relinker - test/shared-skills-install.test.sh and its CI step - docs/qa/p25-shared-skills-inheritance.md — QA procedure for the deleted machinery - the bootstrap.sh invocation and the AGENTS.md install section Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hishboy
added a commit
that referenced
this pull request
Aug 26, 2026
* style: satisfy prettier across the repo Mechanical reformat only — prettier --write over the 11 files the CI "Format check" step reports. No logic changes: the sole token-level deltas are semicolon separators inside inline TypeScript type literals becoming newlines when prettier reflows them (semi: false), plus markdown reflow and quote normalisation. Ten of the eleven were already failing on main before PR #112. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * ci: give the test step a placeholder PRIVY_APP_ID Env.ts returns process.env.PRIVY_APP_ID unvalidated whenever it is set, so presence alone satisfies it. Under vitest NODE_ENV is 'test', so the non-production branch threw at module-import time and five suites failed during collection, before any in-test vi.stubEnv could run. Latent on main, not new: Format check is step 3 and aborted the job before tests ever ran, so this red has never surfaced. Making format pass exposed it. Plain env, not a secret — no test contacts Privy. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes ata's shared-skills install/link machinery outright:
scripts/install-shared-skills.sh— copied the vendoredzipbox-*catalog to/root/skills(0555) and re-pointed repo-rootskills/zipbox-*at it as per-slug symlinkstest/shared-skills-install.test.sh+ its CI step (Shared skills inheritance contract)docs/qa/p25-shared-skills-inheritance.md(QA procedure for the deleted machinery)bootstrap.shinvocation and the AGENTS.md "Installing the skills" install-step proseNo compat symlink is left at
/root/skills— the old path is removed, not repointed.Why
The platform's canonical sandbox skills catalog is moving from
/root/skillsto~/.agents/skills(tribes-protocol/terminal skills-path move). ata's agent is pi, and pi reads~/.agents/skillsnatively (pidocs/skills.md: Global:~/.pi/agent/skills/,~/.agents/skills/), so ata no longer needs to know any sandbox-wide path. The vendoredzipbox-*skills remain real directories under repo-rootskills/(the checkout IS the catalog), discovered through the checked-in.pi/skills → ../skillsand.claude/skills → ../skillssymlinks.bun run skills:upgradevendoring is unchanged.Verified before deleting: nothing in
src/,apps/,agent/, orruntime/reads/root/skillsor the link layer at runtime; the only invoker wasbootstrap.sh:20; the only CI consumer was the deleted step. Remaining mentions are historical records underplans/(deliberately untouched).Sequencing — read before merging
This PR depends on the terminal repo's skills-path move — tribes-protocol/terminal#3654 (canonical dir →
/root/.agents/skills) landing and the harness drive rebaking. Order:~/.agents/skillsin guests).mainat box creation, so new ata boxes pick it up immediately.Merging this FIRST is safe for skill discovery (the repo's own vendored copies still serve via
.pi/skills) but leaves/root/skillsuncreated on new ata boxes while other surfaces still expect the old canonical path — keep the stated order.🤖 Generated with Claude Code