Skip to content

chore(skills): drop the /root/skills install and link layer - #112

Merged
hishboy merged 1 commit into
mainfrom
chore/drop-root-skills-link-layer
Aug 26, 2026
Merged

hishboy merged 1 commit into
mainfrom
chore/drop-root-skills-link-layer

Conversation

@hishboy

@hishboy hishboy commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

What

Deletes ata's shared-skills install/link machinery outright:

  • scripts/install-shared-skills.sh — copied the vendored zipbox-* catalog to /root/skills (0555) and re-pointed repo-root skills/zipbox-* at it as per-slug symlinks
  • test/shared-skills-install.test.sh + its CI step (Shared skills inheritance contract)
  • docs/qa/p25-shared-skills-inheritance.md (QA procedure for the deleted machinery)
  • the bootstrap.sh invocation and the AGENTS.md "Installing the skills" install-step prose

No compat symlink is left at /root/skills — the old path is removed, not repointed.

Why

The platform's canonical sandbox skills catalog is moving from /root/skills to ~/.agents/skills (tribes-protocol/terminal skills-path move). ata's agent is pi, and pi reads ~/.agents/skills natively (pi docs/skills.md: Global: ~/.pi/agent/skills/, ~/.agents/skills/), so ata no longer needs to know any sandbox-wide path. The vendored zipbox-* skills remain real directories under repo-root skills/ (the checkout IS the catalog), discovered through the checked-in .pi/skills → ../skills and .claude/skills → ../skills symlinks. bun run skills:upgrade vendoring is unchanged.

Verified before deleting: nothing in src/, apps/, agent/, or runtime/ reads /root/skills or the link layer at runtime; the only invoker was bootstrap.sh:20; the only CI consumer was the deleted step. Remaining mentions are historical records under plans/ (deliberately untouched).

Sequencing — read before merging

This PR depends on the terminal repo's skills-path move — tribes-protocol/terminal#3654 (canonical dir → /root/.agents/skills) landing and the harness drive rebaking. Order:

  1. Terminal repo skills-move PR merges + fleet harness-drive rebake (that's what creates ~/.agents/skills in guests).
  2. Then this PR merges. ata clones main at box creation, so new ata boxes pick it up immediately.

Merging this FIRST is safe for skill discovery (the repo's own vendored copies still serve via .pi/skills) but leaves /root/skills uncreated on new ata boxes while other surfaces still expect the old canonical path — keep the stated order.

🤖 Generated with Claude Code

The sandbox-wide canonical skills catalog is moving to ~/.agents/skills
(tribes-protocol/terminal skills-path move). ata's agent is pi, which reads
~/.agents/skills natively (pi docs/skills.md: Global: ~/.pi/agent/skills/,
~/.agents/skills/), so this repo no longer installs or links /root/skills
at all. The vendored zipbox-* skills stay as real directories under
repo-root skills/, discovered through the checked-in .pi/skills and
.claude/skills symlinks; skills:upgrade vendoring is unchanged.

Removed outright (no compat path left behind):
- scripts/install-shared-skills.sh — the /root/skills installer + relinker
- test/shared-skills-install.test.sh and its CI step
- docs/qa/p25-shared-skills-inheritance.md — QA procedure for the deleted
  machinery
- the bootstrap.sh invocation and the AGENTS.md install section

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@hishboy
hishboy merged commit 5d737b3 into main Aug 26, 2026
1 check failed
@hishboy
hishboy deleted the chore/drop-root-skills-link-layer branch August 26, 2026 13:22
hishboy added a commit that referenced this pull request Aug 26, 2026
* style: satisfy prettier across the repo

Mechanical reformat only — prettier --write over the 11 files the CI
"Format check" step reports. No logic changes: the sole token-level
deltas are semicolon separators inside inline TypeScript type literals
becoming newlines when prettier reflows them (semi: false), plus
markdown reflow and quote normalisation.

Ten of the eleven were already failing on main before PR #112.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* ci: give the test step a placeholder PRIVY_APP_ID

Env.ts returns process.env.PRIVY_APP_ID unvalidated whenever it is set, so
presence alone satisfies it. Under vitest NODE_ENV is 'test', so the
non-production branch threw at module-import time and five suites failed
during collection, before any in-test vi.stubEnv could run.

Latent on main, not new: Format check is step 3 and aborted the job before
tests ever ran, so this red has never surfaced. Making format pass exposed it.

Plain env, not a secret — no test contacts Privy.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant