Skip to content

fix(sidebar): keep the focus window unique - #26

Merged
hishboy merged 1 commit into
mainfrom
fix/startup-settle-stall
Sep 4, 2026
Merged

hishboy merged 1 commit into
mainfrom
fix/startup-settle-stall

Conversation

@hishboy

@hishboy hishboy commented Sep 4, 2026 •

Copy link
Copy Markdown
Contributor

What this changes

The permanent focus window is created once inside tmux's serialized command queue. A company that already has duplicate focus windows also repairs itself when every removed window is inactive and contains only the exact Chief rail and parked notice.

Why

On 2026-09-04, sparkling-mantis.zbox.sh had two fully owned __focus__ windows. The actuator failed before step zero with Ambiguous duplicate organization window '__focus__': @2, @224; Rio and Vega had desired launch intents but no panes, while settled Rhea remained live. The old check-then-create path existed since the initial public release and treated an empty tmux result as confirmed absence.

Plan: plans/startup-settle-stall.md


Checklist

The standing check list

  • bun run typecheck
  • bun run test
  • bun run lint
  • bun run lint:reactive
  • bun run knip
  • bun run test:pre-push-guards

If this touched apps/chiefd/ at all — comment-only edits included

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets

If this touched genesis, materialization, the launch gate, or the identity/bearer path

  • Not applicable. This changes only the client-owned sidebar focus-window path.

Tests

  • Tests pin the rule this change implements, not merely that the code runs.
  • A bug fix carries a regression test for the exact failure.
  • No existing assertion was weakened or deleted to make this pass.

The focused real-tmux selections pass: 25 focus_ tests and 7 duplicate tests. A negative control that forced both creators through failed with distinct @1 and @2 windows, then passed after the server predicate was restored. The repository guards pass 99/99 on this commit and untouched c38023f, with identical zero not ok lines and pass=99 fail=0 counts. The Rust workspace count guard observed the exact 3,609 tests in 92 suites. Two existing tmux 3.7c precondition tests fail identically on untouched c38023f: chord spelling is normalized as C-M-z instead of the test's M-C-z, and the RGB fixture starts without the old defect it requires. GitHub's matching Rust shards pass both tests in their supported environment.

Record

  • CHANGELOG.md updated with the delivered behaviour.
  • DECISIONS.md has one dated line for the recovery safety boundary.
  • The plan under plans/ is current.
  • Comments carry the reason for the mutation guards.

Provenance

  • Every commit is signed off.

Signed-off-by: hishboy <hishboy@zbox.sh>
@hishboy
hishboy merged commit 5d5f365 into main Sep 4, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant