Repository navigation
fix(sidebar): keep the focus window unique - #26
Merged
Merged
Conversation
Signed-off-by: hishboy <hishboy@zbox.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The permanent focus window is created once inside tmux's serialized command queue. A company that already has duplicate focus windows also repairs itself when every removed window is inactive and contains only the exact Chief rail and parked notice.
Why
On 2026-09-04,
sparkling-mantis.zbox.shhad two fully owned__focus__windows. The actuator failed before step zero withAmbiguous duplicate organization window '__focus__': @2, @224; Rio and Vega had desired launch intents but no panes, while settled Rhea remained live. The old check-then-create path existed since the initial public release and treated an empty tmux result as confirmed absence.Plan:
plans/startup-settle-stall.mdChecklist
The standing check list
bun run typecheckbun run testbun run lintbun run lint:reactivebun run knipbun run test:pre-push-guardsIf this touched
apps/chiefd/at all — comment-only edits includedcargo fmt --all --checkcargo clippy --workspace --all-targetsIf this touched genesis, materialization, the launch gate, or the identity/bearer path
Tests
The focused real-tmux selections pass: 25
focus_tests and 7duplicatetests. A negative control that forced both creators through failed with distinct@1and@2windows, then passed after the server predicate was restored. The repository guards pass 99/99 on this commit and untouchedc38023f, with identical zeronot oklines andpass=99 fail=0counts. The Rust workspace count guard observed the exact 3,609 tests in 92 suites. Two existing tmux 3.7c precondition tests fail identically on untouchedc38023f: chord spelling is normalized asC-M-zinstead of the test'sM-C-z, and the RGB fixture starts without the old defect it requires. GitHub's matching Rust shards pass both tests in their supported environment.Record
CHANGELOG.mdupdated with the delivered behaviour.DECISIONS.mdhas one dated line for the recovery safety boundary.plans/is current.Provenance