Skip to content

Update addressname formatter - #148

Merged
obrusvit merged 1 commit into
mainfrom
pmike/update-addressname
Nov 1, 2026
Merged

obrusvit merged 1 commit into
mainfrom
pmike/update-addressname

Conversation

@PrisionMike

Copy link
Copy Markdown
Collaborator

Counterpart to trezor/trezor-firmware#8142
(FW changes need to be merged first)

@PrisionMike
PrisionMike requested a review from obrusvit October 25, 2026 14:36
@PrisionMike PrisionMike self-assigned this Oct 25, 2026
@PrisionMike
PrisionMike added this pull request to stack #149 October 25, 2026 14:36
@github-project-automation github-project-automation Bot moved this to 🔎 Needs review in Firmware Oct 25, 2026
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1adc24f7-a70f-4ce6-8f20-8815ac1d41e0
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@obrusvit obrusvit left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contract_name_formats in this PR uses different func_sig than the previous PR in the stack (4 vs 8 zero-bytes).

@github-project-automation github-project-automation Bot moved this from 🔎 Needs review to 🏃‍♀️ In progress in Firmware Oct 30, 2026
Base automatically changed from pmike/contract-names to main October 30, 2026 18:17
@PrisionMike
PrisionMike force-pushed the pmike/update-addressname branch from f469678 to 30cd56c Compare October 30, 2026 18:37
@PrisionMike
PrisionMike requested a review from obrusvit November 1, 2026 11:44
@obrusvit
obrusvit merged commit bdc0887 into main Nov 1, 2026
2 checks passed
@obrusvit
obrusvit deleted the pmike/update-addressname branch November 1, 2026 16:28
@obrusvit obrusvit moved this from 🏃‍♀️ In progress to ✅ Done (no QA) in Firmware Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: ✅ Done (no QA)

Development

Successfully merging this pull request may close these issues.

2 participants