Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
SchnozzleCat
previously approved these changes
Mar 31, 2026
b37d1d2
441e0cd to
b37d1d2
Compare
|
🎉 This PR is included in version 8.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All four
merge*utils had the same bug in their shareImage resolution logic:When a page has no
metadata(e.g. the portfolio / index page in pina-projects, wherepage.attributes.metadataisnull), the ternary short-circuits directly toDEFAULT_SHARE_IMAGE— it never considersglobal.attributes.metadata.shareImageas a media source. This is why updating the shareImage in Strapi CMS had no effect.Title and description worked fine because they use
??chains that always reach the global fallback. Only shareImage was affected because of the early ternary exit.Fix
Resolve the media source first (page → global → nothing), then derive the URL:
Applied consistently across all four merge utils:
mergeGlobalAndStrapiPageDatamergeGlobalAndStrapiBlogPostDatamergeGlobalAndStrapiCustomerStoryDatamergeGlobalAndStrapiProjectDataTests
Added 2 new test cases to
mergeGlobalAndStrapiPageData.test.ts:DEFAULT_SHARE_IMAGEwhen neither page nor global has a shareImageAll 50 tests pass.