allow method calls on integers to start with a _#294
Open
m4rch3n1ng wants to merge 3 commits intotree-sitter:masterfrom
Open
allow method calls on integers to start with a _#294m4rch3n1ng wants to merge 3 commits intotree-sitter:masterfrom
_#294m4rch3n1ng wants to merge 3 commits intotree-sitter:masterfrom
Conversation
|
Looks great to me, thank you :) |
m4rch3n1ng
force-pushed
the
int-method-call-underscore
branch
from
551f7e5 to
fe84bf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this basically allows for
42._method()to properly parse as the call of the method_methodon the integer42.the FLOAT_LITERAL reference explicitly states
not immediately followed by ., _ or an XID_Start characterfor the character after an ending dot, so disallow this here too.this fixes exactly one rustc test: integer-literal-method-call-underscore.rs, the test that was for exactly this behaviour.
(noticed this while working on #293)