You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR fixes a bug where having a forward slash between two nested block comments throws an error.
I haven't committed a run to tree-sitter generate as I'm not sure if I should do so for a scanner change or not.
Bug preview (using Zed 0.188.5):
How it looks like in VSCode:
Also added a test to source-files.txt test for demonstration.
It's my first time contributing to tree-sitter so any feedback is appreciated.
Hi @kofta999 , I have noticed that PRs in this repository are infrequently reviewed, so I have integrated your PR in a fork of this grammar. If you use this grammar in Rust, you can benefit from the improvements in this PR by switching to the tree-sitter-rust-orchard crate on crates.io. Let me know if you need the grammar published in another package repository. I would very much welcome more contributions like this one in the fork, to which I would also be happy to give you write access.
Dear maintainers,
Thank you for your work. It is completely understandable that you have higher priorities in life than integrating external contributions in this repository. If you still wish those contributions to get reviewed, I encourage you to give maintainer rights to more people. The list of PRs and the commit log should help you identify trustworthy contributors who might be interested in helping out. Onboarding new contributors might also be easier if you adopt a governance model for this project. If there is any way I can help, let me know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where having a forward slash between two nested block comments throws an error.
I haven't committed a run to
tree-sitter generateas I'm not sure if I should do so for a scanner change or not.Bug preview (using Zed 0.188.5):
How it looks like in VSCode:
Also added a test to
source-files.txttest for demonstration.It's my first time contributing to
tree-sitterso any feedback is appreciated.