Skip to content

fixing bug for plugin cmd #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traoreera merged 1 commit into from
Apr 30, 2026
Merged

fixing bug for plugin cmd #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:

- repo: local
hooks:
- id: lint_fixning
- id: lint
name: lint fixning
Comment on lines +13 to 14

@sourcery-ai sourcery-ai Bot Apr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Align the hook name with the new id and fix the lingering typo.

The id was updated from lint_fixning to lint, but the hook name is still lint fixning with the typo. Please rename the hook (e.g. lint or lint (auto-fix)) and fix the spelling for consistency in pre-commit output.

entry: make lint-fix
language: system
Expand Down
10 changes: 5 additions & 5 deletions xcore/cli/plugin_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ async def _plugin_health(args) -> None:
status.update(f"[bold green]Analyzing {escape(name)}...")
try:
validator = ManifestValidator()
manifest = validator.load_and_validate(plugin_dir_entry)
manifest, _, _ = validator.load_and_validate(plugin_dir_entry)

# Signature
signed = "✅" if is_signed(manifest) else "⚠️ "
Expand Down Expand Up @@ -342,7 +342,7 @@ async def _auto_sign(plugin_dir: Path, cfg) -> None:
from xcore.kernel.security.validation import ManifestValidator

try:
manifest = ManifestValidator().load_and_validate(plugin_dir)
manifest, _, _ = ManifestValidator().load_and_validate(plugin_dir)
except Exception as e:
print(f"⚠️ Signature auto ignorée (manifeste invalide) : {e}")
return
Expand Down Expand Up @@ -404,7 +404,7 @@ async def _plugin_info(args) -> None:

try:
validator = ManifestValidator()
manifest = validator.load_and_validate(plugin_dir)
manifest, _, _ = validator.load_and_validate(plugin_dir)
except Exception as e:
console.print(f"[bold red]❌ Manifeste invalide :[/] {e}")
sys.exit(1)
Expand Down Expand Up @@ -470,7 +470,7 @@ async def _plugin_validate(args) -> None:
sys.exit(1)
try:
v = ManifestValidator()
manifest = v.load_and_validate(path)
manifest, _, _ = v.load_and_validate(path)
console.print(
f"✅ Manifeste valide : {manifest.name} v{manifest.version} "
f"[{manifest.execution_mode.value}]"
Expand All @@ -486,7 +486,7 @@ async def _plugin_sign(args) -> None:

path = Path(args.path)
key = (args.key or "change-me").encode()
manifest = ManifestValidator().load_and_validate(path)
manifest, _, _ = ManifestValidator().load_and_validate(path)
sig = sign_plugin(manifest, key)
print(f"✅ Signé : {sig}")

Expand Down
Loading