Lazy TUI Playlist - #785
Merged
Merged
Conversation
Temporay because this should be asked from the server.
As that adds a "CancellationToken" "PartialEq" impl
As it is not necessary and not compatible with next few commits.
As they are practically never used.
Slightly less cloning and slightly less data to move around. More ergonomic.
So that it does not load more than necessary, if canceled (eg. TUI quit)
Currently known issue: Playlist Total Duration is hard-coded to be unknown.
…HashSet" To ensure no duplicates are loaded.
hasezoey
force-pushed
the
lazyTUIPlaylist
branch
from
September 20, 2026 08:14
1e493f0 to
f67a67f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the TUI Playlist lazy loading.
Currently known limitations:
I would appreciate some additional testing before this is being merged.
Notes about the implementation:
TMPTrackLoadMsg) is a temporary helper actor until the info can be loaded from the server via protobufDepends on #784re #493
Tagging @Porkepix in case you are interested to test this change.