Skip to content

Conversation

@XAMPPRocky
Copy link
Contributor

Thís is very rough cut to fix #174 it at least ensures that it no longer fails to compile.

@XAMPPRocky
Copy link
Contributor Author

@ignatz I've updated the PR with the latest branch, much smaller this time.

I wanted to also add a check in CI for no default features, but it doesn't seem like the current ci actually builds or tests the code? I may be missing something but I don't see a place in the workflow where it runs cargo build or cargo test.

@ignatz
Copy link
Contributor

ignatz commented Jan 5, 2026

Hi @XAMPPRocky, sorry for the very slow reply (back now).

Testing more build-configs (combinatorial explosion aside) at CI time makes sense. Right now CI runs are 20+min would be great to not double.

I wanted to also add a check in CI for no default features, but it doesn't seem like the current ci actually builds or tests the code? I may be missing something but I don't see a place in the workflow where it runs cargo build or cargo test.

It's a bit hidden. It is in the "test" workflow and the cargo test invocation happens through pre-commit:

Additionally all the client-tests have integration tests and run against a build of the trail binary, i.e. you will find cargo build invocations all across the test harnesses in /client/*.

As for the specific code changes, are they still needed? If I check out at head I can run cargo build --no-default-features from the project root w/o issues.

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabling wasm feature triggers compile errors

2 participants