Repository navigation
Conversation
Preserve query-bearing canonical redirects, reject unknown compatibility paths, and remove unreachable disabled API branches. Ultraworked with [omo](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Shadow auto-approve: would not auto-approve because issues were found.
Re-trigger cubic
11 tasks
The direct handler test could not fail for the /api paths: worker.fetch never dispatches /api/* to the password-generator handler. Assert the public contract (site 404, no redirect, no JSON API response) for all six prefixes, their subpaths, GET and POST through the real worker entry, and scope the handler test to what it actually covers. Addresses cubic review PRR_kwDORJtISM8AAAABNS3JAg.
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Canonicalizes HTML aliases and restricts /tools redirects, changing public URL responses, and replaces disabled-API 403s with 404s; the public-contract impact and unreachable-branch claim need human review.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix(routes): canonicalize aliases and constrain compatibility. This is logical change 11/11 in the dependency-ordered product-audit release stack.
Closes #969
What changed
e5c99575be2bdad4286bce4c300fea6cf3f77b17; validated tree:e18ca0944a49196ae72e6dbf332594352c4cb93a.Why
Keep canonical URLs and known compatibility links working while unknown paths correctly return 404.
Verification
bun run buildpassed on this exact candidate tree.npm test -- --maxWorkers=2passed on this exact candidate tree.19 HTTP cases passed, including seven query-preserving HTML aliases, known/unknown compatibility paths, disabled API boundaries, health and favicon; real Korean alias navigation passed.
Final combined tree additionally passed 801 unit tests and all 293 Playwright tests with retries disabled, plus all 48 primary tool workflows at desktop and mobile. The exploratory Color Converter exact-HEX boundary remains a documented pre-existing defect; its runtime is unchanged by this stack.
Risk & rollback
Summary by cubic
Canonicalizes route aliases and constrains
/tools/compatibility redirects so.htmlaliases point to canonical URLs and unknown/toolspaths return 404 instead of being rewritten. Closes #969./index.html,/about.html,/careers.html,/contact.html,/privacy.html,/security.html, and/terms.htmlnow 301 to canonical paths, preserving query strings./tools/*redirects only for registered tools, known legacy redirects, or dev-only compat redirects; unknown suffixes return 404.development.Rollout
Written for commit 67b078c. Summary will update on new commits.