Support line ranges for commit URLs#37
Open
odnoletkov wants to merge 1 commit into
Open
Conversation
Author
|
Relevant |
odnoletkov
force-pushed
the
master
branch
2 times, most recently
from
df6d79f to
669a5f5
Compare
tpope
reviewed
Sep 18, 2019
Anchor format is: #diff-<SHA256 of path>[[L|R]<start line number>[-[L|R]<end line number>]] With L line number is relative to the '---' side, and R to the '+++' side of the diff. Path of the '+++' side used when it exists, otherwise path of the '---' side (for removals). Closes tpope#36
|
@odnoletkov hi! Not sure if that's what blocking this PR, but there are conflicts. |
Owner
|
Conflicts aren't a blocker at this point. |
|
OK, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchor format is
With L line number is relative to the --- side, with R to the +++ side.
Path of the +++ side used when it exists, otherwise path of the --- side
(for removals).