chore: remove Lerna and publishing scripts#72
Merged
Merged
Conversation
Removed `lerna.json`, custom publishing scripts, and related GPG setup from workflows. Simplified the publishing process by migrating to direct npm commands in GitHub Actions. Cleaned up unnecessary dependencies and configurations.
Contributor
WalkthroughUpdates CI publish flow to build and test with Bun, simplify publishing by deriving version from the release tag and running Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor GitHub_Actions as GitHub Actions
participant Repo as Repository
participant Bun as Bun runtime
participant NPM as npm Registry
participant GH as GitHub Release Event
GH-->>GitHub_Actions: release.published (tag_name)
GitHub_Actions->>Repo: actions/checkout
GitHub_Actions->>Bun: setup bun
GitHub_Actions->>Repo: bun install
GitHub_Actions->>Repo: bun run build
GitHub_Actions->>Repo: bun run test
GitHub_Actions->>Repo: derive VERSION (strip leading "v")
GitHub_Actions->>Repo: npm version VERSION --no-git-tag-version
GitHub_Actions->>NPM: npm publish --access public
NPM-->>GitHub_Actions: publish result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.github/workflows/npm-publish.yml (2)
24-28: Verify Foundry is still requiredYou removed Forge-based test execution but still install Foundry. If tests no longer rely on Forge/Foundry, drop this to speed up CI; otherwise keep and call it explicitly.
If not needed, remove:
- - name: Install Foundry - uses: foundry-rs/foundry-toolchain@v1 - with: - version: stable
32-34: Build step looks good; consider reproducibility
- Pin Bun to a specific minor (vs.
latest) for deterministic builds.- Optionally use
bun install --frozen-lockfileand cachebun.lockbto stabilize installs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/npm-publish.yml(2 hunks)lerna.json(0 hunks)scripts/publish-to-npm.sh(0 hunks)
💤 Files with no reviewable changes (2)
- lerna.json
- scripts/publish-to-npm.sh
🔇 Additional comments (1)
.github/workflows/npm-publish.yml (1)
36-36: Confirm test runner coverageSwitching to
bun run testis fine if it invokes all suites. If you still have Forge tests, keep a Foundry run as well or make sure your Bun test script delegates to Forge.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
giuseppecrj
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed
lerna.json, custom publishing scripts, and related GPG setup from workflows. Simplified the publishing process by migrating to direct npm commands in GitHub Actions. Cleaned up unnecessary dependencies and configurations.Summary by CodeRabbit