-
Notifications
You must be signed in to change notification settings - Fork 3
v0.3.52 release #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
v0.3.52 release #219
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d4adedb
feat: pass through error messages from backend when runs fail (#214)
socksy 4bd59a1
feat: add `tower apps cancel` command to cancel running runs (#215)
socksy 01a1643
Bump version to v0.3.52
bradhe 6d703fd
Add a new `is_local` info function (#218)
bradhe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 50371
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 348
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 558
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 2799
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 702
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 129
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 269
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 126
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 41
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 496
🏁 Script executed:
Repository: tower/tower-cli
Length of output: 984
Explicitly set
TOWER__RUNTIME__IS_TOWER_MANAGED=falsein local runs to prevent flag bleed.Local runs inherit the parent environment because
protected_modeisfalse(cache_dir defaults toSome(default_cache_dir()), notNone). This means if the parent tower-cli process hasTOWER__RUNTIME__IS_TOWER_MANAGED=truefrom a prior cloud execution, it will leak into the subprocess. The current code only addsTOWER__RUNTIME__IS_LOCAL=truebut does not explicitly clear the cloud flag, making it possible for bothtower.info.is_cloud_run()andtower.info.is_local()to returnTrue.Required hardening change
env_vars.insert("TOWER_JWT".to_string(), session.token.jwt.to_string()); + env_vars.insert( + "TOWER__RUNTIME__IS_TOWER_MANAGED".to_string(), + "false".to_string(), + ); env_vars.insert("TOWER__RUNTIME__IS_LOCAL".to_string(), "true".to_string());🤖 Prompt for AI Agents