fix: alias mobile source in vite example to avoid prebuild requirement#370
Merged
zztnrudzz13 merged 2 commits intotoss:mainfrom Apr 28, 2026
Merged
Conversation
4 tasks
Collaborator
|
Thanks for your contribution! Would you consider including the build step when running |
Contributor
Author
|
Thanks for the feedback! I've updated the approach to run I also reverted the |
Collaborator
|
Thanks for the changes! |
zztnrudzz13
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #358
When running
yarn example:vitein a clean workspace (no prebuiltdist/), Vite fails to resolve@react-simplikit/mobilebecause the package'sexportsfield points todist/index.js, which doesn't exist yet.This PR adds a
resolve.aliastoexamples/with-vite/vite.config.tsthat maps@react-simplikit/mobiledirectly to its TypeScript source entry (packages/mobile/src/index.ts), so the example dev server works without needing to build workspace packages first.Note: The Next.js example (
with-nextjs) was not affected — it starts successfully even without a prebuild step.Checklist
yarn run fixto format and lint the code and docs?yarn run test:coverageto make sure there is no uncovered line?