Skip to content

Fix line endings, various HidingContainer fixes, missing test deps, GrowingGridLayout validation #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nphilipp wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix line endings, various HidingContainer fixes, missing test deps, GrowingGridLayout validation #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d373ba
convert to Unix line endings
nphilipp Dec 14, 2015
697af9d
fix raising ValidationError
nphilipp Dec 14, 2015
f56cbab
HidingCheckBox: normalize mapping for truth values
nphilipp Dec 14, 2015
064faa9
create state object for validating HidingContainerMixin
nphilipp Dec 17, 2015
8164e32
hide required attribute on hidden form fields
nphilipp Dec 21, 2015
d7821e8
add missing test dependency 'sieve'
nphilipp Mar 23, 2016
483561f
don't let hidden template child fail validation
nphilipp Mar 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'BeautifulSoup',
'strainer',
'WebTest',
'sieve'
],
entry_points="""
[tw2.widgets]
Expand Down
18 changes: 17 additions & 1 deletion tw2/dynforms/static/dynforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,27 @@ function twd_hiding_onchange(ctrl)
for(a in mapping)
for(b in mapping[a])
{
var display = visible[mapping[a][b]] ? '' : 'none';
var is_visible = visible[mapping[a][b]]
var display = is_visible ? '' : 'none';
var req_from = is_visible ? '_twd_hidden_required' : 'required';
var req_to = is_visible ? 'required' : '_twd_hidden_required';
var x = document.getElementById(parent_id+mapping[a][b]+':container');
if(x.style.display != display)
{
x.style.display = display;

// Set/hide required attribute on children where applicable
var children = x.getElementsByTagName('*');
for(var i = 0; i < children.length; i++)
{
c = children[i];
if(c.hasAttribute(req_from))
{
c.setAttribute(req_to, c.getAttribute(req_from));
c.removeAttribute(req_from);
}
}

var x = document.getElementById(parent_id+mapping[a][b]);
if(x && x.id && twd_mapping_store[x.id])
twd_hiding_onchange(x);
Expand Down
Loading