[torlando-tech]

Follow-up to #98 (merged). Physical testing of the inline-images feature on a cycling partial-region page found that images inside a dynamic (partial) region never load in Pyxis: the compact-page merge adds their records, but the image loader was configured only on full page load, so region images stay alt-text placeholders forever. The official NomadNet client renders them because its image updater rescans page images after every partial update.

Fix: ImageLoader::reconfigure rebuilds the entry list from the merged page, keyed by (image_index, cache_key):

• unchanged (index, url) pairs keep state verbatim — LOADED stays loaded, no refetch
• replaced urls at the same index are re-admitted fresh (no stale pixels)
• new indices admitted under the same policy gate as the full-page configure
• an in-flight REQUESTING entry whose record was replaced in flight is reported orphaned so the caller releases the outstanding receipt (seal-then-release) before the next request

UIManager::nomad_reconfigure_images_after_partial mirrors the full-page configure (policy/loopback/RTT/EDR), runs after each applied fragment, and surfaces manual-mode pending state.

Verification: 6 new loader scenarios (shrink / grow / in-place replace / in-flight orphan / in-flight preserved / manual / never); native suite 311 passed; tdeck + tdeck-release build; release audit pass (pins unchanged); x86 real-peer flow 11/11.

[greptile-apps]

Confidence Score: 3/5

The PR is not ready to merge because partial refreshes can strand both previously displayed images and an in-flight image request.

Findings

1.  Loaded images lose their pixels ▶
2.  Allocation failure strands image requests ▶

Fix with agent prompt

### Issue 1
lib/tdeck_ui/UI/LXMF/NomadNetImageLoader.cpp:121-125
When a partial refresh adds an image after four images are already displayed, storing the new image evicts one of the screen’s four decoded pixel slots. This branch still preserves the evicted image’s `LOADED` state, so the loader never fetches it again and the unchanged part of the page shows a placeholder. The loader needs to account for decoded-slot eviction when preserving loaded state.

### Issue 2
lib/tdeck_ui/UI/LXMF/NomadNetImageLoader.cpp:169-172
If allocation fails while rebuilding the entries, this returns `false` and retains the old loader state. The caller treats `false` as an orphaned request and releases its receipt, even if the in-flight image is unchanged. That entry remains `REQUESTING` without a request, so later polls will not fetch it or advance past it. Allocation failure needs a result distinct from an orphaned request, or the retained entry must be reconciled when its receipt is released.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

The PR rebuilds NomadNet image-loader entries after an applied partial refresh, preserving unchanged entries and admitting new or replaced image records. It also releases orphaned image requests and adds loader scenarios for refresh and policy behavior.

• New region images can load, but admitting them can evict pixels for images whose loader state remains LOADED.
• Allocation failure can leave a retained request entry stuck after its receipt is released.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Partial fragment applied] --> B[Rebuild image entries]
  B --> C{Same index and cache key?}
  C -->|Yes| D[Preserve loader state]
  C -->|No| E[Admit under policy gate]
  E --> F{Old request orphaned?}
  F -->|Yes| G[Seal mailbox and release receipt]
  F -->|No| H[Poll pending images]
  G --> H

Loading

_{Reviews (1) · Last reviewed commit: "fix(nomadnet): load images that arrive v..."}

[greptile-apps]

Loaded images lose their pixels When a partial refresh adds an image after four images are already displayed, storing the new image evicts one of the screen’s four decoded pixel slots. This branch still preserves the evicted image’s LOADED state, so the loader never fetches it again and the unchanged part of the page shows a placeholder. The loader needs to account for decoded-slot eviction when preserving loaded state.

Knowledge Base Used: NomadNet browser

Prompt To Fix With AI

This is a comment left during a code review.
Path: lib/tdeck_ui/UI/LXMF/NomadNetImageLoader.cpp
Line: 121-125

Comment:
**Loaded images lose their pixels** When a partial refresh adds an image after four images are already displayed, storing the new image evicts one of the screen’s four decoded pixel slots. This branch still preserves the evicted image’s `LOADED` state, so the loader never fetches it again and the unchanged part of the page shows a placeholder. The loader needs to account for decoded-slot eviction when preserving loaded state.

**Knowledge Base Used:** [NomadNet browser](https://app.greptile.com/torlando-tech/-/custom-context/knowledge-base/torlando-tech/pyxis/-/docs/nomadnet-browser.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[greptile-apps]

Allocation failure strands image requests If allocation fails while rebuilding the entries, this returns false and retains the old loader state. The caller treats false as an orphaned request and releases its receipt, even if the in-flight image is unchanged. That entry remains REQUESTING without a request, so later polls will not fetch it or advance past it. Allocation failure needs a result distinct from an orphaned request, or the retained entry must be reconciled when its receipt is released.

Prompt To Fix With AI

This is a comment left during a code review.
Path: lib/tdeck_ui/UI/LXMF/NomadNetImageLoader.cpp
Line: 169-172

Comment:
**Allocation failure strands image requests** If allocation fails while rebuilding the entries, this returns `false` and retains the old loader state. The caller treats `false` as an orphaned request and releases its receipt, even if the in-flight image is unchanged. That entry remains `REQUESTING` without a request, so later polls will not fetch it or advance past it. Allocation failure needs a result distinct from an orphaned request, or the retained entry must be reconciled when its receipt is released.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.