Repository navigation
ui: remove 'Disable Background Transport' button from explainer sheet - #217
Merged
Merged
Conversation
The Start/Stop control in the Reticulum Network settings card is the authoritative way to stop the tunnel. The explainer sheet's disable button is now redundant - remove it. The enable button remains for the not-yet-enabled state.
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Greptile P1: removing the explainer sheet's disable button left no in-app stop while the tunnel is .connecting or .reasserting, because the card's Start/Stop used tunnel.isRunning (true only for .connected) and would show 'Start' in those states. Add reticulumIsOn() mirroring the explainer's isEnabledState (on for connected/connecting/reasserting/disconnecting) and use it for the card button's action, label, and color. User can now cancel a slow connect or in-progress stop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Start/Stop control in the Reticulum Network settings card is the authoritative way to stop the tunnel. The explainer sheet's disable button is redundant now - remove it. The enable button remains for the not-yet-enabled state.