fix(keycodes): correct MetaRight and ContextMenu descriptions#346
Open
ginsarix wants to merge 1 commit intotoptal:mainfrom
Open
fix(keycodes): correct MetaRight and ContextMenu descriptions#346ginsarix wants to merge 1 commit intotoptal:mainfrom
ginsarix wants to merge 1 commit intotoptal:mainfrom
Conversation
- Add "Right ⌘" to MetaRight to match MetaLeft consistency. - Remove "Right ⌘" from ContextMenu as it is incorrect for Mac layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two inconsistencies in the keyboard key descriptions:
MetaRight missing "Right ⌘": While MetaLeft correctly includes "Left ⌘" in its description, MetaRight was missing the corresponding "Right ⌘" label.
ContextMenu incorrectly labeled: The ContextMenu key currently shows "Right ⌘", but this doesn't match the physical layout of Mac keyboards
These changes improve accuracy and maintain consistency across the keyboard layout descriptions.
How to test
Acceptance Criteria
Pre-merge checklist
main(if not - rebase it).Related Issues
Fixes #345