modify getKeyCodeEvent to match better. Fixes 336#338
Open
wesbos wants to merge 1 commit intotoptal:mainfrom
Open
modify getKeyCodeEvent to match better. Fixes 336#338wesbos wants to merge 1 commit intotoptal:mainfrom
wesbos wants to merge 1 commit intotoptal:mainfrom
Conversation
macap
suggested changes
Feb 3, 2023
macap
left a comment
macap
left a comment
There was a problem hiding this comment.
Thank you for contributing, @wesbos!
However, whereas this PR does fix the delete key description (as well as some other keys)
it actually causes incorrect behavior in other keys, such as:
Which is also confirmed by the broken E2E pipeline.
We have added this to our backlog, but we’ll still appreciate contributions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When toptal updated the codebase, the logic for finding the keycode was too strict. It was expecting both the .code and the .key - so that filtered out descriptions on keys without one of those values. Importantly this was excluding every single modifier key - like
Shift + abeing codeA.Easy fix - it should a bit more relaxed on finding. The code first, if not, the key.
Fixes #334