feat(descriptions): expand information for key and code#318
Open
cwadrupldijjit wants to merge 1 commit intotoptal:main-legacyfrom
Open
feat(descriptions): expand information for key and code#318cwadrupldijjit wants to merge 1 commit intotoptal:main-legacyfrom
cwadrupldijjit wants to merge 1 commit intotoptal:main-legacyfrom
Conversation
### What Changed? - add more explanations about behavior of `.key` and `.code` event properties - add `cross-env` to allow for Windows users to run the app with the node options supplied in the env ### Issues Addressed: - N/A ### Issue Testing: - Manual Developer Testing ### Test Results: 1. Open browser to running application 1. Read the descriptions on the page for the `.key` and `.code` values 1. See that they add clarity to the behavior of their respective properties
cwadrupldijjit
requested review from
afzaalahmad and
macap
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed?
.keyand.codeevent propertiesdeprecatedcross-envto allow for Windows users to run the app with the node options supplied in the envIssues Addressed:
Issue Testing:
Test Results:
.keyand.codevalues