Improve codebase#6
Merged
Merged
Conversation
For easier testing and better lib ergonomics
Whitespace and vertical alignment.
Fixed * Unused extensions * Unused imports * Missing type signatures
Contributor
Author
|
Ready for review! |
Revert to having three exposed modules:
Data.SGF
Data.SGF.Parse
Data.SGF.Types
Far from ergonomic, but at least it will not break API.
Owner
|
Hey @ffaf1 I'm no longer interested in maintaining this library, would you be interested in becoming the new maintainer. |
Contributor
Author
|
Thanks for the offer Toni.
I cannot answer with a definite yes/no right now, but I am working with
the library and in the next months for sure I will have an answer!
Il 29 settembre 2025 alle 07:56 Toni Cebrián ha scritto:
… tonicebrian left a comment (tonicebrian/sgf#6)
Hey @ffaf1 I'm no longer interested in maintaining this library, would you be interested in becoming the new maintainer.
--
Reply to this email directly or view it on GitHub:
#6 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Owner
|
Ok, let me know if or when do you finally want to take ownership. In order to merge this PR could you please make these 2 changes:
Thanks!! |
Contributor
Author
|
Ok, done! |
tonicebrian
approved these changes
Oct 20, 2025
Owner
|
Thanks @ffaf1 . Let me know if you want to take it as a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
While fixing the relevant bug I restructured the codebase:
.cabalfileIf this kind of work is appreciated and gets merged, I will continue.