[WIP] Don't merge - these are for discussion #1
[WIP] Don't merge - these are for discussion #1timhughes wants to merge 11 commits intotomtastic:mainfrom
Conversation
the module source code is all contained in the src directory which makes for easier testing and keep it separate from the rest of the cruft that a project needs
they are bulshit ones from gemini so you will need to check over them all with a fine toothed comb
tomtastic
left a comment
tomtastic
left a comment
There was a problem hiding this comment.
Thanks, I had experimented with a few directory structures with varying levels of success, especially when it came to getting things like mypy to pick up imports correctly.
There was a problem hiding this comment.
I didn't know about this, nice!
There was a problem hiding this comment.
No idea why I failed to run black against these, but yeah, good stuff.
| @property | ||
| def issuer(self) -> list[str]: | ||
| """Issuer.""" | ||
| return [ |
There was a problem hiding this comment.
Nice, this nested list comp solves a lot of ugliness, thanks
| ext_key_usage_object = self.cert.extensions.get_extension_for_oid( | ||
| ExtensionOID.EXTENDED_KEY_USAGE | ||
| ).value | ||
| for usage in ext_key_usage_object.__dict__["_usages"]: |
There was a problem hiding this comment.
Is there a way I can avoid this calling of dunder methods with private sounding key names?
| authorityInfoAccess = self.cert.extensions.get_extension_for_oid( | ||
| ExtensionOID.AUTHORITY_INFORMATION_ACCESS | ||
| ) | ||
| for access in authorityInfoAccess.value: |
There was a problem hiding this comment.
This inspection of object values seemed clunky, but I didn't know another way to do it, is there a better way?
| repos: | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v5.0.0 | ||
| hooks: |
There was a problem hiding this comment.
I did not know you could do this, sweet!
2 participants
No description provided.