Fix spurious rotation back-and-forth when collecting post-scan flat f…#178
Open
Fix spurious rotation back-and-forth when collecting post-scan flat f…#178
Conversation
…ields (reported as issue #177) When SampleOutAngleEnable=Yes and FlatFieldMode=End or Both, end_scan() called move_sample_in() which restored self.rotation_save to the end-of-scan angle. ReturnRotation then immediately moved the rotation to rotation_start, producing an unnecessary intermediate move (e.g. SampleOutAngle → rotation_stop → rotation_start). Fix: clear self.rotation_save before move_sample_in() in end_scan() so only the X/Y stage is moved back. ReturnRotation in the base end_scan() handles the final rotation position. Affects all beamlines using TomoScanPSO: 2-BM, 7-BM, 13-BM, 32-ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
SampleOutAngleEnableis set toYesandFlatFieldModeis set toEndorBoth,the rotation stage performs two unnecessary extra moves at the end of the scan resulting in rotation travels
90° → 180° → 0°instead of simply90° → 0°. (reported as issue #177)Fix: clear self.rotation_save before move_sample_in() in end_scan() so only the X/Y stage is moved back. ReturnRotation in the base end_scan() handles the final rotation position.
Affects all beamlines using TomoScanPSO: 2-BM, 7-BM, 13-BM, 32-ID.