Skip to content

Simplify GH actions#170

Draft
tommyod wants to merge 13 commits into
masterfrom
simplify
Draft

Simplify GH actions#170
tommyod wants to merge 13 commits into
masterfrom
simplify

Conversation

@tommyod

@tommyod tommyod commented Sep 1, 2024

Copy link
Copy Markdown
Owner

Now we have master and develop, as well as a manual trigger. It's not clear to me what the expected workflow is to integrate changes into pypi. Can it be simplified?

  • This PR is an attempt to simplify the GH actions: yse one .yaml file that does everything.
  • The motivation behind splitting it in the first place is found here.

What are your thoughts @whitews ? The changes that were made in october 2023 when it was split was probably made for a reason. We should either simplify, or document better.

@tommyod tommyod mentioned this pull request Oct 29, 2024
@tommyod tommyod marked this pull request as draft October 29, 2024 07:09
@philipp-horstenkamp

Copy link
Copy Markdown
Contributor

How did you plan to simplifiy this?

@whitews

whitews commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

Hey Tommy,

Sorry I missed this. The CI changes made back then were to allow test suites to run on either the develop or the master branches on pushed commits, while isolating the PyPI builds to the master branch. The PyPI builds were set to be triggered manually as a safe guard for failing master commits. The logic being that new releases are infrequent enough that manual triggers shouldn't pose such a burden versus the risks of publishing broken packages. Apologies if the intention of those changes was unclear, the CI stuff on GitHub can be a maze. Feel free to change as you deem appropriate, I was just trying to be mindful of the increasing number of downstream packages depending on this library.

Kind regards,
Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants