Allow justinrainbow/json-schema to use v6 if necessary #166
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v6 is required by composer/composer library since v2.8.7 and causes dependency issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v6 is required by composer/composer library since v2.8.7 and causes dependency issues.
All recent releases of
composer/composerwere flagged as vulnerable. The fix is included inv2.9.3which requiresjustinrainbow/json-schemav6 which is incompatible with the current version of Nette API.I've checked the v6 changes and they seem to be compatible for use in this library and therefore it should be OK to allow v5 OR v6 installation - see https://github.com/jsonrainbow/json-schema/releases/tag/6.0.0.
If possible, please cherry pick this also for v2 tag so that it could be used with 2.12 version.