Fix CI: bump MSRV to 1.88 and gate doc-test on broker-wam feature - #2
Open
tolgaki wants to merge 1 commit into
Open
Fix CI: bump MSRV to 1.88 and gate doc-test on broker-wam feature#2tolgaki wants to merge 1 commit into
tolgaki wants to merge 1 commit into
Conversation
Two CI jobs were failing on main: - MSRV (1.75): Cargo.lock is v4 (needs Cargo 1.78+), and transitive deps require newer toolchains: getrandom 0.4.2 needs edition2024 (1.85+) and time 0.3.47 needs 1.88. Bump rust-version and the CI pin to 1.88, the actual minimum the dependency graph supports. - Test (windows-latest): doc-test in client/public.rs gated only on target_os = "windows", not on the broker-wam feature, so on a default-feature build the block compiles and references msal::broker::wam::WamBroker, which is itself feature-gated. Same bug PR #1 fixed in broker/mod.rs but missed here. Add the feature flag to the cfg. Verified locally: cargo +1.88 check, cargo +1.88 test (21 lib + 57 integration + 7 doc tests all pass), cargo fmt --check, cargo clippy -Dwarnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI jobs were failing on main:
MSRV (1.75): Cargo.lock is v4 (needs Cargo 1.78+), and transitive
deps require newer toolchains: getrandom 0.4.2 needs edition2024
(1.85+) and time 0.3.47 needs 1.88. Bump rust-version and the CI
pin to 1.88, the actual minimum the dependency graph supports.
Test (windows-latest): doc-test in client/public.rs gated only on
target_os = "windows", not on the broker-wam feature, so on a
default-feature build the block compiles and references
msal::broker::wam::WamBroker, which is itself feature-gated. Same
bug PR Fix WAM broker build on Windows #1 fixed in broker/mod.rs but missed here. Add the feature
flag to the cfg.
Verified locally: cargo +1.88 check, cargo +1.88 test (21 lib + 57
integration + 7 doc tests all pass), cargo fmt --check, cargo clippy
-Dwarnings.