Skip to content

feat(tools): Normalized detected shell names to lowercase on Windows#109

Merged
floitsch merged 1 commit intopatch-head-5.4.1from
floitsch/patch-head-5.4.1-pwsh.EXE
Oct 18, 2025
Merged

feat(tools): Normalized detected shell names to lowercase on Windows#109
floitsch merged 1 commit intopatch-head-5.4.1from
floitsch/patch-head-5.4.1-pwsh.EXE

Conversation

@floitsch
Copy link
Copy Markdown
Member

@floitsch floitsch commented Oct 4, 2025

@floitsch floitsch requested a review from kasperl October 4, 2025 19:26
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 4, 2025

Warnings
⚠️

The source branch "floitsch/patch-head-5.4.1-pwsh.EXE" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello floitsch, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 142fa38

@floitsch
Copy link
Copy Markdown
Member Author

TBR.

@floitsch floitsch merged commit 178220b into patch-head-5.4.1 Oct 18, 2025
3 checks passed
@floitsch floitsch deleted the floitsch/patch-head-5.4.1-pwsh.EXE branch October 18, 2025 17:44
floitsch added a commit that referenced this pull request Oct 18, 2025
…109)

Co-authored-by: Marek Fiala <marek.fiala@espressif.com>
Copy link
Copy Markdown

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants