Skip to content

Don't set a pull-up for RMT-RX.#107

Merged
floitsch merged 1 commit intopatch-head-5.4.1from
floitsch/patch-head-5.4.1-no-rmt-pullup
Jun 17, 2025
Merged

Don't set a pull-up for RMT-RX.#107
floitsch merged 1 commit intopatch-head-5.4.1from
floitsch/patch-head-5.4.1-no-rmt-pullup

Conversation

@floitsch
Copy link
Copy Markdown
Member

@floitsch floitsch commented Jun 6, 2025

This same change was applied to ESP-IDF master:
espressif@c63f51d

This same change was applied to ESP-IDF master:
espressif@c63f51d
@floitsch floitsch requested a review from kasperl June 6, 2025 08:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 6, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Don't set a pull-up for RMT-RX.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello floitsch, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 7758dc7

Copy link
Copy Markdown

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@floitsch floitsch merged commit bb7015a into patch-head-5.4.1 Jun 17, 2025
3 checks passed
@floitsch floitsch deleted the floitsch/patch-head-5.4.1-no-rmt-pullup branch June 17, 2025 10:59
floitsch added a commit that referenced this pull request Oct 18, 2025
This same change was applied to ESP-IDF master:
espressif@c63f51d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants