fix: add close_code and close_notes when resolving SNow incident#136
Merged
Conversation
ServiceNow data policy requires both fields when setting state to Resolved (6). Omitted for non-success outcomes so the failure path is unaffected. Closes #135 Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close_codeandclose_noteswhen moving an incident to Resolved (state 6) — without them the PATCH returns HTTP 403.close_code: "Solved (Permanently)"andclose_notes(same content as the success work note) to the PATCH payload inupdate_incident.ymlwheninc_outcome == success.omitfor non-success outcomes so the In Progress / failure path is unaffected.Closes #135
🤖 Generated with Claude Code