Open
Conversation
don't use pygtail anymore since it doesnt support gzipped logs
- disable msm logroll - disable logroll on pre shutdown backup
|
Just an FYI, while this fix indeed did seem to work ok (tested it with some of my buddies on our server and player tracking worked), it's likely a bit over-engineered for what the fix needs to do. It's better than nothing, but it could probably be better. I just haven't played minecraft in a while and thus never revisited this project. |
Owner
Author
|
I'm running them currently, and I haven't noticed anything yet. |
Author
|
I've continued to run these changes and haven't noticed any serious issues. There are occasionally times where it's not quite up-to-date but it's never caused a problem. It's certainly better than no player information at all without this fix, so I'd recommend merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like @dmotles made some changes for Minecraft 1.7.2, would be nice if they were in the base repo.