tockloader: fix crash reshuffling apps with no kernel present - #141
Merged
Conversation
_reshuffle_apps() logged the RAM start address with a `{:#02x}` format
spec before the None-guard that immediately follows it, even though
_get_memory_start_address() can legitimately return None (e.g. an
empty flash image, or a TBF with a fixed flash address but no fixed
RAM address). That raised:
TypeError: unsupported format string passed to NoneType.__format__
any time `install`/`update` ran against a board with no kernel written
yet (e.g. a freshly registered `local-board` with a zero flash base).
The line was also redundant: the very next debug line already prints
the same value via the pre-guarded ram_start_address_hex, so it is
simply removed.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KTQ6pWrckM3jp9vfBo4bhk
brghena
approved these changes
Sep 1, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr—delete a redundant logging line that crashes in some cases.
_reshuffle_apps() logged the RAM start address with a
{:#02x}format spec before the None-guard that immediately follows it, even though_get_memory_start_address()can legitimately returnNone(e.g. an empty flash image, or a TBF with a fixed flash address but no fixed RAM address). That raised:any time
install/updateran against a board with no kernel written yet (e.g. a freshly registeredlocal-boardwith a zero flash base). The line was also redundant: the very next debug line already prints the same value via the pre-guardedram_start_address_hex, so it is simply removed.Claude-Session: https://claude.ai/code/session_01KTQ6pWrckM3jp9vfBo4bhk