Introduce x86 to Libtock-rs#569
Merged
alevy merged 3 commits intotock:masterfrom Oct 9, 2025
HMiyaziwala:master
Merged
Conversation
2 tasks
2 tasks
6 tasks
bradjc
approved these changes
Oct 9, 2025
alevy
reviewed
Oct 9, 2025
|
|
||
| # Common settings for all embedded targets | ||
| [target.'cfg(any(target_arch = "arm", target_arch = "riscv32"))'] | ||
| [target.'cfg(any(target_arch = "arm", target_arch = "riscv32", target_arch = "x86"))'] |
Member
There was a problem hiding this comment.
Noting here (but not for this PR) that it's not clear this is target cfg makes any sense anymore really. If this is meant to distinguish between compiling for a target device vs compiling for the host (e.g. to run tests), this won't last. Sure, none of us are developing on riscv32, but we might develop on arm and soon enough we'll probably have an x86_64 target.
Collaborator
There was a problem hiding this comment.
Several years ago I spent some time trying to find a better way to do this (separate host from target in Cargo configuration) and failed. Maybe I missed something, or maybe something's improved, or maybe the situation is still bad, but in any case I agree that this test is not great and won't last.
alevy
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces x86 startup and syscall assembly to Libtock-rs.
Follows the existing patterns established by the ARM and RISC-V implementations.