Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions crates/polyglot-sql/src/generator.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22122,12 +22122,23 @@ impl Generator {
match f.style {
ParameterStyle::Question => self.write("?"),
ParameterStyle::Dollar => {
self.write("$");
if let Some(idx) = f.index {
self.write(&idx.to_string());
} else if let Some(ref name) = f.name {
// Session variable like $x or $query_id
self.write(name);
if matches!(
self.config.dialect,
Some(DialectType::TSQL) | Some(DialectType::Fabric)
) {
self.write("@P");
self.write(&idx.to_string());
} else {
self.write("$");
self.write(&idx.to_string());
}
} else {
self.write("$");
if let Some(ref name) = f.name {
// Session variable like $x or $query_id
self.write(name);
}
}
}
ParameterStyle::DollarBrace => {
Expand Down
5 changes: 5 additions & 0 deletions crates/polyglot-sql/tests/fabric_regression.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ fn tsql_to_fabric(sql: &str) -> String {
.expect("expected at least one statement")
}

#[test]
fn postgres_positional_parameters_render_as_tsql_style_placeholders_for_fabric() {
assert_eq!(pg_to_fabric("SELECT $1, $2"), "SELECT @P1, @P2");
}

// ---------------------------------------------------------------------------
// PostgreSQL LATERAL joins -> Fabric APPLY
// ---------------------------------------------------------------------------
Expand Down
5 changes: 5 additions & 0 deletions crates/polyglot-sql/tests/tsql_regression.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,11 @@ fn tsql_max_length_types_parse_generate_and_transpile() {
assert!(!postgres[0].is_empty());
}

#[test]
fn postgres_positional_parameters_render_as_tsql_style_placeholders() {
assert_eq!(pg_to_tsql("SELECT $1, $2"), "SELECT @P1, @P2");
}

#[test]
fn tsql_datepart_dayofweek_generates_valid_tsql_datepart() {
let cases = [
Expand Down