Repository navigation
feat: add extension icons - #11
Merged
Merged
Conversation
There were none — no icons key in the manifest and no image files at all. Chrome fell back to a generated letter tile, and the Web Store requires a 128x128 before an extension can be listed. The icons are generated by a script rather than committed as opaque binaries. This machine has no image tooling at all (no Pillow, ImageMagick, rsvg or inkscape), and adding a dependency to a repository whose selling point is having none seemed the wrong trade — so make-icons.mjs writes the PNGs directly, the way package.mjs already writes the zip. The shape lives in one vector definition, so changing the colour or the form means editing two lines and re-running it. The artwork is a white folder on a blue rounded square, identical at every size. It was checked at 16px, where anything with fine detail turns to mush; the tab still reads there. npm run check now verifies that every file the manifest names actually exists, icons included, and that a 128 is present. Generated assets are the ones most likely to go missing from a package. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
アイコンが一つも無かった。manifest に
iconsキーが無く、画像ファイルも 0 枚。Chrome は頭文字のタイルを自動生成して表示していた。ウェブストアは 128x128 を必須にしているので、掲載の前提としても要る。生成スクリプトにした理由
この機体には画像ツールが 1 つも入っていない（Pillow / ImageMagick / rsvg / inkscape すべて無し）。依存ゼロを売りにしているリポジトリに依存を足すのは筋が悪いので、
make-icons.mjsが PNG を直接書いている。package.mjsが zip を直接書いているのと同じ理屈。形はベクタ定義 1 箇所（角丸長方形 2 つの和）で決まるので、色や形を変えたければ 2 行いじって
npm run iconsで作り直せる。バイナリを不透明なまま置くより、あとで直せる。図案
青の角丸正方形に白いフォルダ。全サイズ同一。16px で確認済みで、細かい装飾は潰れるが、タブの段差はこの大きさでも読める。
check の強化
npm run checkが manifest の参照するファイルの実在を全部見るようにした（アイコンを含む）。128 が無ければ落ちる。生成物はパッケージから漏れやすいので。iconsとaction.default_iconが同じパスを指すぶんは重複を畳んでいる。アイコンを 1 枚消して落ちること、
npm run packageの zip に 4 枚とも入ることを確認済み。🤖 Generated with Claude Code